refactor: remove locally caught exceptions

pull/532/head
Jef LeCompte 2022-08-04 09:33:09 -07:00
parent 94f88d78c4
commit 3a1b76e782
No known key found for this signature in database
GPG Key ID: 7F5BA322B5DC170C
2 changed files with 12 additions and 21 deletions

7
dist/setup/index.js vendored
View File

@ -71780,18 +71780,13 @@ function parseNodeVersionFile(contents) {
core.warning('Node version file is not JSON file'); core.warning('Node version file is not JSON file');
} }
if (!nodeVersion) { if (!nodeVersion) {
try {
const found = contents.match(/^(?:nodejs\s+)?v?(?<version>[^\s]+)$/m); const found = contents.match(/^(?:nodejs\s+)?v?(?<version>[^\s]+)$/m);
nodeVersion = (_c = found === null || found === void 0 ? void 0 : found.groups) === null || _c === void 0 ? void 0 : _c.version; nodeVersion = (_c = found === null || found === void 0 ? void 0 : found.groups) === null || _c === void 0 ? void 0 : _c.version;
if (!nodeVersion)
throw new Error();
} }
catch (err) {
// In the case of an unknown format, // In the case of an unknown format,
// return as is and evaluate the version separately. // return as is and evaluate the version separately.
if (!nodeVersion)
nodeVersion = contents.trim(); nodeVersion = contents.trim();
}
}
return nodeVersion; return nodeVersion;
} }
exports.parseNodeVersionFile = parseNodeVersionFile; exports.parseNodeVersionFile = parseNodeVersionFile;

View File

@ -506,17 +506,13 @@ export function parseNodeVersionFile(contents: string): string {
} }
if (!nodeVersion) { if (!nodeVersion) {
try {
const found = contents.match(/^(?:nodejs\s+)?v?(?<version>[^\s]+)$/m); const found = contents.match(/^(?:nodejs\s+)?v?(?<version>[^\s]+)$/m);
nodeVersion = found?.groups?.version; nodeVersion = found?.groups?.version;
}
if (!nodeVersion) throw new Error();
} catch (err) {
// In the case of an unknown format, // In the case of an unknown format,
// return as is and evaluate the version separately. // return as is and evaluate the version separately.
nodeVersion = contents.trim(); if (!nodeVersion) nodeVersion = contents.trim();
}
}
return nodeVersion as string; return nodeVersion as string;
} }