From 902046e4d8056014468f5a9f8907fde2b0514eee Mon Sep 17 00:00:00 2001 From: bethanyj28 Date: Mon, 26 Feb 2024 09:36:35 -0500 Subject: [PATCH 1/2] ensure callback is only called once --- packages/artifact/src/internal/download/download-artifact.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/artifact/src/internal/download/download-artifact.ts b/packages/artifact/src/internal/download/download-artifact.ts index 09890c29..2880c536 100644 --- a/packages/artifact/src/internal/download/download-artifact.ts +++ b/packages/artifact/src/internal/download/download-artifact.ts @@ -128,10 +128,7 @@ export async function streamExtractExternal( if (!createdDirectories.has(path.dirname(fullPath))) { createdDirectories.add(path.dirname(fullPath)) await resolveOrCreateDirectory(path.dirname(fullPath)).then( - () => { - entry.autodrain() - callback() - } + () => {} ) } From dcc55dfd0485545474048b888c6167aa9206d92c Mon Sep 17 00:00:00 2001 From: bethanyj28 Date: Mon, 26 Feb 2024 09:56:00 -0500 Subject: [PATCH 2/2] feedback --- packages/artifact/src/internal/download/download-artifact.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/artifact/src/internal/download/download-artifact.ts b/packages/artifact/src/internal/download/download-artifact.ts index 2880c536..c30d65f2 100644 --- a/packages/artifact/src/internal/download/download-artifact.ts +++ b/packages/artifact/src/internal/download/download-artifact.ts @@ -127,9 +127,7 @@ export async function streamExtractExternal( } else { if (!createdDirectories.has(path.dirname(fullPath))) { createdDirectories.add(path.dirname(fullPath)) - await resolveOrCreateDirectory(path.dirname(fullPath)).then( - () => {} - ) + await resolveOrCreateDirectory(path.dirname(fullPath)) } const writeStream = createWriteStream(fullPath)