1
0
Fork 0

Rename option to lookupOnly

pull/1286/head
Marc Mueller 2023-01-17 17:12:42 +01:00
parent eb06c21794
commit a3849b77ae
4 changed files with 14 additions and 14 deletions

View File

@ -9,7 +9,7 @@ const useAzureSdk = true
const downloadConcurrency = 8 const downloadConcurrency = 8
const timeoutInMs = 30000 const timeoutInMs = 30000
const segmentTimeoutInMs = 3600000 const segmentTimeoutInMs = 3600000
const dryRun = false const lookupOnly = false
const uploadConcurrency = 4 const uploadConcurrency = 4
const uploadChunkSize = 32 * 1024 * 1024 const uploadChunkSize = 32 * 1024 * 1024
@ -21,7 +21,7 @@ test('getDownloadOptions sets defaults', async () => {
downloadConcurrency, downloadConcurrency,
timeoutInMs, timeoutInMs,
segmentTimeoutInMs, segmentTimeoutInMs,
dryRun lookupOnly
}) })
}) })
@ -31,7 +31,7 @@ test('getDownloadOptions overrides all settings', async () => {
downloadConcurrency: 14, downloadConcurrency: 14,
timeoutInMs: 20000, timeoutInMs: 20000,
segmentTimeoutInMs: 3600000, segmentTimeoutInMs: 3600000,
dryRun: true lookupOnly: true
} }
const actualOptions = getDownloadOptions(expectedOptions) const actualOptions = getDownloadOptions(expectedOptions)
@ -65,7 +65,7 @@ test('getDownloadOptions overrides download timeout minutes', async () => {
downloadConcurrency: 14, downloadConcurrency: 14,
timeoutInMs: 20000, timeoutInMs: 20000,
segmentTimeoutInMs: 3600000, segmentTimeoutInMs: 3600000,
dryRun: true lookupOnly: true
} }
process.env.SEGMENT_DOWNLOAD_TIMEOUT_MINS = '10' process.env.SEGMENT_DOWNLOAD_TIMEOUT_MINS = '10'
const actualOptions = getDownloadOptions(expectedOptions) const actualOptions = getDownloadOptions(expectedOptions)
@ -76,5 +76,5 @@ test('getDownloadOptions overrides download timeout minutes', async () => {
) )
expect(actualOptions.timeoutInMs).toEqual(expectedOptions.timeoutInMs) expect(actualOptions.timeoutInMs).toEqual(expectedOptions.timeoutInMs)
expect(actualOptions.segmentTimeoutInMs).toEqual(600000) expect(actualOptions.segmentTimeoutInMs).toEqual(600000)
expect(actualOptions.dryRun).toEqual(expectedOptions.dryRun) expect(actualOptions.lookupOnly).toEqual(expectedOptions.lookupOnly)
}) })

View File

@ -280,7 +280,7 @@ test('restore with cache found for restore key', async () => {
test('restore with dry run', async () => { test('restore with dry run', async () => {
const paths = ['node_modules'] const paths = ['node_modules']
const key = 'node-test' const key = 'node-test'
const options = {dryRun: true} const options = {lookupOnly: true}
const cacheEntry: ArtifactCacheEntry = { const cacheEntry: ArtifactCacheEntry = {
cacheKey: key, cacheKey: key,

View File

@ -100,8 +100,8 @@ export async function restoreCache(
return undefined return undefined
} }
if (options?.dryRun) { if (options?.lookupOnly) {
core.info('Dry run - skipping download') core.info('Lookup only - skipping download')
return cacheEntry.cacheKey return cacheEntry.cacheKey
} }

View File

@ -56,12 +56,12 @@ export interface DownloadOptions {
/** /**
* Weather to skip downloading the cache entry. * Weather to skip downloading the cache entry.
* If dryRun is set to true, the restore function will only check if * If lookupOnly is set to true, the restore function will only check if
* a matching cache entry exists and return the cache key if it does. * a matching cache entry exists and return the cache key if it does.
* *
* @default false * @default false
*/ */
dryRun?: boolean lookupOnly?: boolean
} }
/** /**
@ -102,7 +102,7 @@ export function getDownloadOptions(copy?: DownloadOptions): DownloadOptions {
downloadConcurrency: 8, downloadConcurrency: 8,
timeoutInMs: 30000, timeoutInMs: 30000,
segmentTimeoutInMs: 3600000, segmentTimeoutInMs: 3600000,
dryRun: false lookupOnly: false
} }
if (copy) { if (copy) {
@ -122,8 +122,8 @@ export function getDownloadOptions(copy?: DownloadOptions): DownloadOptions {
result.segmentTimeoutInMs = copy.segmentTimeoutInMs result.segmentTimeoutInMs = copy.segmentTimeoutInMs
} }
if (typeof copy.dryRun === 'boolean') { if (typeof copy.lookupOnly === 'boolean') {
result.dryRun = copy.dryRun result.lookupOnly = copy.lookupOnly
} }
} }
const segmentDownloadTimeoutMins = const segmentDownloadTimeoutMins =
@ -143,7 +143,7 @@ export function getDownloadOptions(copy?: DownloadOptions): DownloadOptions {
`Cache segment download timeout mins env var: ${process.env['SEGMENT_DOWNLOAD_TIMEOUT_MINS']}` `Cache segment download timeout mins env var: ${process.env['SEGMENT_DOWNLOAD_TIMEOUT_MINS']}`
) )
core.debug(`Segment download timeout (ms): ${result.segmentTimeoutInMs}`) core.debug(`Segment download timeout (ms): ${result.segmentTimeoutInMs}`)
core.debug(`Dry run: ${result.dryRun}`) core.debug(`Lookup only: ${result.lookupOnly}`)
return result return result
} }