1
0
Fork 0

Change casing for endLine and endColumn

pull/855/head
Luke Tomlinson 2021-07-02 14:49:28 -04:00
parent 4b50f8c52c
commit a5df6ef8f5
2 changed files with 7 additions and 9 deletions

View File

@ -280,7 +280,7 @@ describe('@actions/core', () => {
endLine: 5
})
assertWriteCalls([
`::error title=A title,line=5,end_line=5,col=1,end_column=2::Error: ${message}${os.EOL}`
`::error title=A title,line=5,endLine=5,col=1,endColumn=2::Error: ${message}${os.EOL}`
])
})
@ -310,7 +310,7 @@ describe('@actions/core', () => {
endLine: 5
})
assertWriteCalls([
`::warning title=A title,line=5,end_line=5,col=1,end_column=2::Error: ${message}${os.EOL}`
`::warning title=A title,line=5,endLine=5,col=1,endColumn=2::Error: ${message}${os.EOL}`
])
})
@ -324,14 +324,12 @@ describe('@actions/core', () => {
})
expect(commandProperties.title).toBe('A title')
expect(commandProperties.col).toBe(1)
expect(commandProperties.end_column).toBe(2)
expect(commandProperties.endColumn).toBe(2)
expect(commandProperties.line).toBe(5)
expect(commandProperties.end_line).toBe(5)
expect(commandProperties.endLine).toBe(5)
expect(commandProperties.startColumn).toBeUndefined()
expect(commandProperties.endColumn).toBeUndefined()
expect(commandProperties.startLine).toBeUndefined()
expect(commandProperties.endLine).toBeUndefined()
})
it('startGroup starts a new group', () => {

View File

@ -20,7 +20,7 @@ export function toCommandValue(input: any): string {
/**
*
* @param annotationProperties
* @returns The command properties to send with the actual annotaiton command
* @returns The command properties to send with the actual annotation command
* See: https://github.com/actions/runner/blob/ee34f4842e747b452e13235836c92b2bb1606816/src/Runner.Worker/ActionCommandManager.cs#L566
*/
export function toCommandProperties(
@ -33,8 +33,8 @@ export function toCommandProperties(
return {
title: annotationProperties.title,
line: annotationProperties.startLine,
end_line: annotationProperties.endLine,
endLine: annotationProperties.endLine,
col: annotationProperties.startColumn,
end_column: annotationProperties.endColumn
endColumn: annotationProperties.endColumn
}
}