1
0
Fork 0

Spelling (#72)

* spelling: check in

* spelling: compatibility

* spelling: definitely

* spelling: does not

* spelling: maintaining

* spelling: nonexistent

* spelling: precede

* spelling: response

* spelling: was not
pull/75/head
Josh Soref 2019-08-21 15:31:44 -04:00 committed by Danny McCormick
parent 7d605994f9
commit ad054c855d
7 changed files with 12 additions and 12 deletions

View File

@ -13,9 +13,9 @@ steps:
Binding to the immutable sha1 of a released version is the safest for stability and security.
Binding to a specific major version allows for receiving critical fixes and security patches while still mainting compatibility and the assurance your workflow should still work.
Binding to a specific major version allows for receiving critical fixes and security patches while still maintaining compatibility and the assurance your workflow should still work.
Binding to master is convenient but if a new major version is released which breaks compatilibility, your workflow could break.
Binding to master is convenient but if a new major version is released which breaks compatibility, your workflow could break.
# Recommendations

View File

@ -70,7 +70,7 @@ try {
core.debug('Inside try block');
if (!myInput) {
core.warning('myInput wasnt set');
core.warning('myInput was not set');
}
// Do stuff

View File

@ -16,7 +16,7 @@ const testEnvVars = {
// Set inputs
INPUT_MY_INPUT: 'val',
INPUT_MISSING: '',
'INPUT_SPECIAL_CHARS_\'\t"\\': '\'\t"\\ repsonse '
'INPUT_SPECIAL_CHARS_\'\t"\\': '\'\t"\\ response '
}
describe('@actions/core', () => {
@ -101,7 +101,7 @@ describe('@actions/core', () => {
)
})
it('getInput doesnt throw on missing non-required input', () => {
it('getInput does not throw on missing non-required input', () => {
expect(core.getInput('missing', {required: false})).toBe('')
})
@ -110,7 +110,7 @@ describe('@actions/core', () => {
})
it('getInput handles special characters', () => {
expect(core.getInput('special chars_\'\t"\\')).toBe('\'\t"\\ repsonse')
expect(core.getInput('special chars_\'\t"\\')).toBe('\'\t"\\ response')
})
it('setOutput produces the correct command', () => {

View File

@ -14,7 +14,7 @@ interface CommandProperties {
*
* Examples:
* ##[warning]This is the user warning message
* ##[set-secret name=mypassword]definatelyNotAPassword!
* ##[set-secret name=mypassword]definitelyNotAPassword!
*/
export function issueCommand(
command: string,

View File

@ -216,7 +216,7 @@ export class ToolRunner extends events.EventEmitter {
// command line from libuv quoting rules would look like:
// foo.exe "myarg:\"my val\""
//
// 3) double-up slashes that preceed a quote,
// 3) double-up slashes that precede a quote,
// e.g. hello \world => "hello \world"
// hello\"world => "hello\\""world"
// hello\\"world => "hello\\\\""world"

View File

@ -88,7 +88,7 @@ describe('cp', () => {
})
it('copies directory into non-existing destination with -r', async () => {
const root: string = path.join(getTestTemp(), 'cp_with_-r_nonexisting_dest')
const root: string = path.join(getTestTemp(), 'cp_with_-r_nonexistent_dest')
const sourceFolder: string = path.join(root, 'cp_source')
const sourceFile: string = path.join(sourceFolder, 'cp_source_file')
@ -245,7 +245,7 @@ describe('mv', () => {
it('moves directory into non-existing destination', async () => {
const root: string = path.join(
getTestTemp(),
' mv_with_-r_nonexisting_dest'
' mv_with_-r_nonexistent_dest'
)
const sourceFolder: string = path.join(root, ' mv_source')
const sourceFile: string = path.join(sourceFolder, ' mv_source_file')
@ -321,7 +321,7 @@ describe('rmRF', () => {
await assertNotExists(testPath)
})
it('removes folder that doesnt exist with rmRF', async () => {
it('removes folder that does not exist with rmRF', async () => {
const testPath = path.join(getTestTemp(), 'testFolder')
await assertNotExists(testPath)