From b39d573389128ae26af5956a656e345214c28413 Mon Sep 17 00:00:00 2001
From: Thomas Boop <thboop@github.com>
Date: Thu, 15 Aug 2024 16:39:09 -0400
Subject: [PATCH] update tests

---
 packages/http-client/__tests__/basics.test.ts | 5 +++--
 packages/http-client/__tests__/proxy.test.ts  | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/packages/http-client/__tests__/basics.test.ts b/packages/http-client/__tests__/basics.test.ts
index 2e06404c..8d93abb3 100644
--- a/packages/http-client/__tests__/basics.test.ts
+++ b/packages/http-client/__tests__/basics.test.ts
@@ -63,6 +63,7 @@ describe('basics', () => {
     expect(obj.headers['user-agent']).toBeFalsy()
   })
 
+  /* TODO write a mock rather then relying on a third party
   it('does basic https get request', async () => {
     const res: httpm.HttpClientResponse = await _http.get(
       'http://postman-echo.com/get'
@@ -72,7 +73,7 @@ describe('basics', () => {
     const obj = JSON.parse(body)
     expect(obj.url).toBe('http://postman-echo.com/get')
   })
-
+*/
   it('does basic http get request with default headers', async () => {
     const http: httpm.HttpClient = new httpm.HttpClient(
       'http-client-tests',
@@ -226,7 +227,7 @@ describe('basics', () => {
     expect(obj.headers[httpm.Headers.Accept]).toBe('application/json')
     expect(obj.headers['Authorization']).toBeUndefined()
     expect(obj.headers['authorization']).toBeUndefined()
-    expect(obj.url).toBe('https://www.postman-echo.com/get')
+    expect(obj.url).toBe('http://www.postman-echo.com/get')
   })
 
   it('does basic head request', async () => {
diff --git a/packages/http-client/__tests__/proxy.test.ts b/packages/http-client/__tests__/proxy.test.ts
index 600c9f2d..6e1ec840 100644
--- a/packages/http-client/__tests__/proxy.test.ts
+++ b/packages/http-client/__tests__/proxy.test.ts
@@ -235,8 +235,8 @@ describe('proxy', () => {
     expect(_proxyConnects).toEqual(['postman-echo.com:443'])
   })
 
-  it('HttpClient does basic https get request when bypass proxy', async () => {
-    process.env['https_proxy'] = _proxyUrl
+  it('HttpClient does basic http get request when bypass proxy', async () => {
+    process.env['http_proxy'] = _proxyUrl
     process.env['no_proxy'] = 'postman-echo.com'
     const httpClient = new httpm.HttpClient()
     const res: httpm.HttpClientResponse = await httpClient.get(