From b719dac88bd979032c0a07295602241da069dbff Mon Sep 17 00:00:00 2001 From: Prajjwal Date: Mon, 3 Jun 2024 16:40:16 +0530 Subject: [PATCH] adds better error handling --- packages/warp-cache/package.json | 2 +- packages/warp-cache/src/cache.ts | 2 +- packages/warp-cache/src/internal/cacheHttpClient.ts | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/warp-cache/package.json b/packages/warp-cache/package.json index 0ee528d8..fffed1ed 100644 --- a/packages/warp-cache/package.json +++ b/packages/warp-cache/package.json @@ -1,6 +1,6 @@ { "name": "github-actions.warp-cache", - "version": "1.1.13", + "version": "1.1.14", "preview": true, "description": "Github action to use WarpBuild's in-house cache offering", "keywords": [ diff --git a/packages/warp-cache/src/cache.ts b/packages/warp-cache/src/cache.ts index 33b98d07..b21bef5a 100644 --- a/packages/warp-cache/src/cache.ts +++ b/packages/warp-cache/src/cache.ts @@ -368,7 +368,7 @@ export async function saveCache( // Calculate number of chunks required. This is only required if backend is S3 as Google Cloud SDK will do it for us const uploadOptions = getUploadOptions() const maxChunkSize = uploadOptions?.uploadChunkSize ?? 32 * 1024 * 1024 // Default 32MB - const numberOfChunks = Math.min( + const numberOfChunks = Math.max( Math.floor(archiveFileSize / maxChunkSize), 1 ) diff --git a/packages/warp-cache/src/internal/cacheHttpClient.ts b/packages/warp-cache/src/internal/cacheHttpClient.ts index c83f999d..f0f20f32 100644 --- a/packages/warp-cache/src/internal/cacheHttpClient.ts +++ b/packages/warp-cache/src/internal/cacheHttpClient.ts @@ -379,6 +379,9 @@ export async function saveCache( !S3UploadId || !S3UploadKey ) { + core.debug( + `S3 params are not set. Number of Chunks: ${S3NumberOfChunks}, PreSigned URLs: ${S3PreSignedURLs}, Upload ID: ${S3UploadId}, Upload Key: ${S3UploadKey}` + ) throw new Error( 'Unable to upload cache to S3. One of the following required parameters is missing: numberOfChunks, preSignedURLs, uploadId, uploadKey.' )