From d615bc4ddf042f4f6737946549151e573c028e33 Mon Sep 17 00:00:00 2001
From: Konrad Pabjan <konradpabjan@github.com>
Date: Thu, 17 Aug 2023 12:23:09 -0400
Subject: [PATCH] More cleanup

---
 .github/workflows/artifact-tests.yml              |  2 ++
 .../artifact/__tests__/ci-test-action/action.yml  |  5 -----
 .../artifact/__tests__/ci-test-action/index.js    | 15 ---------------
 3 files changed, 2 insertions(+), 20 deletions(-)
 delete mode 100644 packages/artifact/__tests__/ci-test-action/action.yml
 delete mode 100644 packages/artifact/__tests__/ci-test-action/index.js

diff --git a/.github/workflows/artifact-tests.yml b/.github/workflows/artifact-tests.yml
index ed5e0381..d3541984 100644
--- a/.github/workflows/artifact-tests.yml
+++ b/.github/workflows/artifact-tests.yml
@@ -73,5 +73,7 @@ jobs:
 
             if (!success) {
               throw new Error('Failed to upload artifact')
+            } else {
+              console.log(`Successfully uploaded artifact ${id}`)
             }
            
diff --git a/packages/artifact/__tests__/ci-test-action/action.yml b/packages/artifact/__tests__/ci-test-action/action.yml
deleted file mode 100644
index 4d954edd..00000000
--- a/packages/artifact/__tests__/ci-test-action/action.yml
+++ /dev/null
@@ -1,5 +0,0 @@
-name: 'Set env variables'
-description: 'Sets certain env variables so that e2e artifact upload, list, get and download can be tested in a shell'
-runs:
-  using: 'node16'
-  main: 'index.js'
\ No newline at end of file
diff --git a/packages/artifact/__tests__/ci-test-action/index.js b/packages/artifact/__tests__/ci-test-action/index.js
deleted file mode 100644
index bfd5830c..00000000
--- a/packages/artifact/__tests__/ci-test-action/index.js
+++ /dev/null
@@ -1,15 +0,0 @@
-// Certain env variables are not set by default in a shell context and are only available in a node context from a running action
-// In order to be able to upload and download artifacts e2e in a shell when running CI tests, we need these env variables set
-const fs = require('fs');
-const os = require('os');
-const filePath = process.env[`GITHUB_ENV`]
-
-fs.appendFileSync(filePath, `ACTIONS_RESULTS_URL=${process.env.ACTIONS_RESULTS_URL}${os.EOL}`, {
-    encoding: 'utf8'
-})
-fs.appendFileSync(filePath, `ACTIONS_RUNTIME_TOKEN=${process.env.ACTIONS_RUNTIME_TOKEN}${os.EOL}`, {
-    encoding: 'utf8'
-})
-fs.appendFileSync(filePath, `GITHUB_RUN_ID=${process.env.GITHUB_RUN_ID}${os.EOL}`, {
-    encoding: 'utf8'
-})
\ No newline at end of file