1
0
Fork 0

removing promise wrap

pull/1690/head
Vallie Joseph 2024-04-08 17:39:15 +00:00
parent 6e1d7543c4
commit da5e926162
2 changed files with 18 additions and 20 deletions

View File

@ -43,11 +43,10 @@ export async function createZipUploadStream(
const zipUploadStream = new ZipUploadStream(bufferSize) const zipUploadStream = new ZipUploadStream(bufferSize)
zip.pipe(zipUploadStream) zip.pipe(zipUploadStream)
// register callbacks for various events during the zip lifecycle // register callbacks for various events during the zip lifecycle
zip.on('warning', zipWarningCallback)
zip.on('error', zipErrorCallback) zip.on('error', zipErrorCallback)
zip.on('warning', zipWarningCallback)
zip.on('finish', zipFinishCallback) zip.on('finish', zipFinishCallback)
zip.on('end', zipEndCallback) zip.on('end', zipEndCallback)
const addFileToZip = ( const addFileToZip = (
file: UploadZipSpecification, file: UploadZipSpecification,
callback: (error?: Error) => void callback: (error?: Error) => void
@ -75,24 +74,23 @@ export async function createZipUploadStream(
} }
} }
return new Promise((resolve, reject) => {
async.eachSeries(uploadSpecification, addFileToZip, (error: unknown) => { async.eachSeries(uploadSpecification, addFileToZip, (error: unknown) => {
if (error) { if (error) {
core.error('Failed to add a file to the zip:') core.error('Failed to add a file to the zip:')
core.info(error.toString()) // Convert error to string core.info(error.toString()) // Convert error to string
reject(error)
return return
} }
zip.finalize() // Finalize the archive once all files have been added zip.finalize() // Finalize the archive once all files have been added
})
core.debug( core.debug(
`Zip write high watermark value ${zipUploadStream.writableHighWaterMark}` `Zip write high watermark value ${zipUploadStream.writableHighWaterMark}`
) )
core.debug( core.debug(
`Zip read high watermark value ${zipUploadStream.readableHighWaterMark}` `Zip read high watermark value ${zipUploadStream.readableHighWaterMark}`
) )
resolve(zipUploadStream)
}) return zipUploadStream
})
} }
// eslint-disable-next-line @typescript-eslint/no-explicit-any // eslint-disable-next-line @typescript-eslint/no-explicit-any