1
0
Fork 0

Fix linting

fhammerl/port-runne-proxy-tests
Ferenc Hammerl 2023-03-01 16:29:38 +00:00
parent b708d5ba60
commit e4ae385d1a
2 changed files with 36 additions and 33 deletions

View File

@ -223,7 +223,7 @@ describe('proxy', () => {
expect(_proxyConnects).toEqual(['httpbin.org:443'])
})
it('HttpClient does basic https get request when bypass proxy', async () => {
it('HttpClient does basic https get request when bypass proxy', async () => {
process.env['https_proxy'] = _proxyUrl
process.env['no_proxy'] = 'httpbin.org'
const httpClient = new httpm.HttpClient()
@ -235,15 +235,15 @@ it('HttpClient does basic https get request when bypass proxy', async () => {
const obj = JSON.parse(body)
expect(obj.url).toBe('https://httpbin.org/get')
expect(_proxyConnects).toHaveLength(0)
})
})
it('HttpClient bypasses proxy for loopback addresses (localhost, ::1, 127.*)', async () => {
it('HttpClient bypasses proxy for loopback addresses (localhost, ::1, 127.*)', async () => {
// setup a server listening on localhost:8091
var server = http.createServer(function (request, response) {
response.writeHead(200);
request.pipe(response);
});
await server.listen(8091)
const server = http.createServer(function(request, response) {
response.writeHead(200)
request.pipe(response)
})
server.listen(8091)
try {
process.env['http_proxy'] = _proxyUrl
const httpClient = new httpm.HttpClient()
@ -252,14 +252,13 @@ it('HttpClient bypasses proxy for loopback addresses (localhost, ::1, 127.*)', a
)
expect(res.message.statusCode).toBe(200)
const body: string = await res.readBody()
expect(body).toEqual('');
expect(body).toEqual('')
// proxy at _proxyUrl was ignored
expect(_proxyConnects).toEqual([])
} finally {
server.close()
}
finally {
await server.close()
}
})
})
it('proxyAuth not set in tunnel agent when authentication is not provided', async () => {
process.env['https_proxy'] = 'http://127.0.0.1:8080'

View File

@ -74,5 +74,9 @@ export function checkBypass(reqUrl: URL): boolean {
function isLoopbackAddress(host: string): boolean {
const hostUpper = host.toUpperCase()
return hostUpper === 'LOCALHOST' || hostUpper.startsWith('127.') || hostUpper.startsWith('::1')
return (
hostUpper === 'LOCALHOST' ||
hostUpper.startsWith('127.') ||
hostUpper.startsWith('::1')
)
}