1
0
Fork 0

consume new pb wrappers

pull/1591/head
Rob Herley 2023-11-30 19:10:07 +00:00 committed by GitHub
parent 695bf98f84
commit e9d6649a14
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 24 additions and 28 deletions

View File

@ -12,6 +12,7 @@ import type { PartialMessage } from "@protobuf-ts/runtime";
import { reflectionMergePartial } from "@protobuf-ts/runtime"; import { reflectionMergePartial } from "@protobuf-ts/runtime";
import { MESSAGE_TYPE } from "@protobuf-ts/runtime"; import { MESSAGE_TYPE } from "@protobuf-ts/runtime";
import { MessageType } from "@protobuf-ts/runtime"; import { MessageType } from "@protobuf-ts/runtime";
import { Int64Value } from "../../../google/protobuf/wrappers";
import { StringValue } from "../../../google/protobuf/wrappers"; import { StringValue } from "../../../google/protobuf/wrappers";
import { Timestamp } from "../../../google/protobuf/timestamp"; import { Timestamp } from "../../../google/protobuf/timestamp";
/** /**
@ -107,17 +108,17 @@ export interface ListArtifactsRequest {
*/ */
workflowJobRunBackendId: string; workflowJobRunBackendId: string;
/** /**
* (optional) Name of the artifact to filter on * Name of the artifact to filter on
* *
* @generated from protobuf field: string name_filter = 3; * @generated from protobuf field: google.protobuf.StringValue name_filter = 3;
*/ */
nameFilter: string; nameFilter?: StringValue; // optional
/** /**
* (optional) Monolith Database ID of the artifact to filter on * Monolith Database ID of the artifact to filter on
* *
* @generated from protobuf field: int64 id_filter = 4; * @generated from protobuf field: google.protobuf.Int64Value id_filter = 4;
*/ */
idFilter: string; idFilter?: Int64Value; // optional
} }
/** /**
* @generated from protobuf message github.actions.results.api.v1.ListArtifactsResponse * @generated from protobuf message github.actions.results.api.v1.ListArtifactsResponse
@ -453,12 +454,12 @@ class ListArtifactsRequest$Type extends MessageType<ListArtifactsRequest> {
super("github.actions.results.api.v1.ListArtifactsRequest", [ super("github.actions.results.api.v1.ListArtifactsRequest", [
{ no: 1, name: "workflow_run_backend_id", kind: "scalar", T: 9 /*ScalarType.STRING*/ }, { no: 1, name: "workflow_run_backend_id", kind: "scalar", T: 9 /*ScalarType.STRING*/ },
{ no: 2, name: "workflow_job_run_backend_id", kind: "scalar", T: 9 /*ScalarType.STRING*/ }, { no: 2, name: "workflow_job_run_backend_id", kind: "scalar", T: 9 /*ScalarType.STRING*/ },
{ no: 3, name: "name_filter", kind: "scalar", T: 9 /*ScalarType.STRING*/ }, { no: 3, name: "name_filter", kind: "message", T: () => StringValue },
{ no: 4, name: "id_filter", kind: "scalar", T: 3 /*ScalarType.INT64*/ } { no: 4, name: "id_filter", kind: "message", T: () => Int64Value }
]); ]);
} }
create(value?: PartialMessage<ListArtifactsRequest>): ListArtifactsRequest { create(value?: PartialMessage<ListArtifactsRequest>): ListArtifactsRequest {
const message = { workflowRunBackendId: "", workflowJobRunBackendId: "", nameFilter: "", idFilter: "0" }; const message = { workflowRunBackendId: "", workflowJobRunBackendId: "" };
globalThis.Object.defineProperty(message, MESSAGE_TYPE, { enumerable: false, value: this }); globalThis.Object.defineProperty(message, MESSAGE_TYPE, { enumerable: false, value: this });
if (value !== undefined) if (value !== undefined)
reflectionMergePartial<ListArtifactsRequest>(this, message, value); reflectionMergePartial<ListArtifactsRequest>(this, message, value);
@ -475,11 +476,11 @@ class ListArtifactsRequest$Type extends MessageType<ListArtifactsRequest> {
case /* string workflow_job_run_backend_id */ 2: case /* string workflow_job_run_backend_id */ 2:
message.workflowJobRunBackendId = reader.string(); message.workflowJobRunBackendId = reader.string();
break; break;
case /* string name_filter */ 3: case /* google.protobuf.StringValue name_filter */ 3:
message.nameFilter = reader.string(); message.nameFilter = StringValue.internalBinaryRead(reader, reader.uint32(), options, message.nameFilter);
break; break;
case /* int64 id_filter */ 4: case /* google.protobuf.Int64Value id_filter */ 4:
message.idFilter = reader.int64().toString(); message.idFilter = Int64Value.internalBinaryRead(reader, reader.uint32(), options, message.idFilter);
break; break;
default: default:
let u = options.readUnknownField; let u = options.readUnknownField;
@ -499,12 +500,12 @@ class ListArtifactsRequest$Type extends MessageType<ListArtifactsRequest> {
/* string workflow_job_run_backend_id = 2; */ /* string workflow_job_run_backend_id = 2; */
if (message.workflowJobRunBackendId !== "") if (message.workflowJobRunBackendId !== "")
writer.tag(2, WireType.LengthDelimited).string(message.workflowJobRunBackendId); writer.tag(2, WireType.LengthDelimited).string(message.workflowJobRunBackendId);
/* string name_filter = 3; */ /* google.protobuf.StringValue name_filter = 3; */
if (message.nameFilter !== "") if (message.nameFilter)
writer.tag(3, WireType.LengthDelimited).string(message.nameFilter); StringValue.internalBinaryWrite(message.nameFilter, writer.tag(3, WireType.LengthDelimited).fork(), options).join();
/* int64 id_filter = 4; */ /* google.protobuf.Int64Value id_filter = 4; */
if (message.idFilter !== "0") if (message.idFilter)
writer.tag(4, WireType.Varint).int64(message.idFilter); Int64Value.internalBinaryWrite(message.idFilter, writer.tag(4, WireType.LengthDelimited).fork(), options).join();
let u = options.writeUnknownFields; let u = options.writeUnknownFields;
if (u !== false) if (u !== false)
(u == true ? UnknownFieldHandler.onWrite : u)(this.typeName, message, writer); (u == true ? UnknownFieldHandler.onWrite : u)(this.typeName, message, writer);

View File

@ -107,9 +107,7 @@ export async function downloadArtifactInternal(
const listReq: ListArtifactsRequest = { const listReq: ListArtifactsRequest = {
workflowRunBackendId, workflowRunBackendId,
workflowJobRunBackendId, workflowJobRunBackendId
nameFilter: '',
idFilter: '0' // TODO(robherley): zero values are awkward, use pb wrappers
} }
const {artifacts} = await artifactClient.ListArtifacts(listReq) const {artifacts} = await artifactClient.ListArtifacts(listReq)

View File

@ -9,7 +9,7 @@ import {GetArtifactResponse} from '../shared/interfaces'
import {getBackendIdsFromToken} from '../shared/util' import {getBackendIdsFromToken} from '../shared/util'
import {getUserAgentString} from '../shared/user-agent' import {getUserAgentString} from '../shared/user-agent'
import {internalArtifactTwirpClient} from '../shared/artifact-twirp-client' import {internalArtifactTwirpClient} from '../shared/artifact-twirp-client'
import {ListArtifactsRequest} from '../../generated' import {ListArtifactsRequest, StringValue} from '../../generated'
export async function getArtifactPublic( export async function getArtifactPublic(
artifactName: string, artifactName: string,
@ -81,8 +81,7 @@ export async function getArtifactInternal(
const req: ListArtifactsRequest = { const req: ListArtifactsRequest = {
workflowRunBackendId, workflowRunBackendId,
workflowJobRunBackendId, workflowJobRunBackendId,
nameFilter: artifactName, nameFilter: StringValue.create({value: artifactName})
idFilter: '0' // TODO(robherley): int64 zero value, change this to be optional
} }
const res = await artifactClient.ListArtifacts(req) const res = await artifactClient.ListArtifacts(req)

View File

@ -111,9 +111,7 @@ export async function listArtifactsInternal(): Promise<ListArtifactsResponse> {
const req: ListArtifactsRequest = { const req: ListArtifactsRequest = {
workflowRunBackendId, workflowRunBackendId,
workflowJobRunBackendId, workflowJobRunBackendId
nameFilter: '',
idFilter: '0' // TODO(robherley): zero values are awkward, use pb wrappers
} }
const res = await artifactClient.ListArtifacts(req) const res = await artifactClient.ListArtifacts(req)