Enes Cakir
932ba2e7b2
[cache] Use Azure SDK to restore cache always if explicitly set to true
...
With the new cache service v2, `restoreCacheV2` [^1] and `saveCacheV2`
[^2] now explicitly use the Azure SDK for blob operations.
The cacheHttpClient uses the Azure SDK to save the cache if the
`useAzureSdk` option is set to true. [^3]
However, it may not use the Azure SDK to download the cache even if the
`useAzureSdk` option is set to true. If the signed URL does not end with
"blob.core.windows.net," it will not use the Azure SDK to restore the
cache. [^4]
To ensure consistent behavior between saving and restoring the cache,
the Azure SDK should be used to restore the cache if the `useAzureSdk`
option is explicitly set to true.
This PR ensures that the Azure SDK is used to restore the cache whenever
the `useAzureSdk` option is set to true.
[^1]: 1f7c2c79e0/packages/cache/src/cache.ts (L224)
[^2]: 1f7c2c79e0/packages/cache/src/cache.ts (L472)
[^3]: 1f7c2c79e0/packages/cache/src/internal/cacheHttpClient.ts (L335-L343)
[^4]: 1f7c2c79e0/packages/cache/src/internal/cacheHttpClient.ts (L153)
2025-01-24 16:27:40 +03:00
Josh Gross
1f7c2c79e0
[tool-cache] Update `@actions/core` and prepare 2.0.2 release ( #1872 )
...
* Update `@actions/core` and prepare 2.0.2 release
* Include these changes in the release notes
2025-01-15 15:57:09 -05:00
Yang Cao
3095d112ef
Prep release packages/artifact v2.2.1
2025-01-08 21:11:59 +00:00
Yang Cao
e55409315f
Rename the prefix to be more specific
2025-01-08 20:32:45 +00:00
Yang Cao
d4385a64a7
Concurrency has a min of 1
2025-01-08 18:14:04 +00:00
Yang Cao
ede05b95d7
Make concurrency change opt-in, but can only go lower
2025-01-08 18:11:38 +00:00
Yang Cao
f3c12d5561
Set default concurrency to 10 and make timeout configurable
2025-01-08 16:19:09 +00:00
Josh Gross
01f21badd5
Remove more unused cache APIs
2024-12-17 14:51:57 -05:00
Josh Gross
26f8f84a96
Remove unused cache API ( #1907 )
2024-12-17 14:04:05 -05:00
Brian DeHamer
4426b4ea91
Prepare artifact release 2.2.0
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2024-12-17 10:05:45 -08:00
Brian DeHamer
1e0c16f0dc
return artifact digest on upload
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2024-12-06 14:27:46 -08:00
Bassem Dghaidi
cd9197e9bd
Add announcement link
2024-12-04 08:23:10 -08:00
Bassem Dghaidi
72447df44c
Update deprecation notice
2024-12-04 05:33:47 -08:00
Bassem Dghaidi
59845ec372
Update deprecation notice
2024-12-04 05:30:50 -08:00
Bassem Dghaidi
cb001af8a3
Update README to include deprecation notice
2024-12-03 02:52:39 -08:00
Bassem Dghaidi
4498687c5e
Prepare @actions/cache 4.0.0 release
2024-12-03 02:40:00 -08:00
Bassem Dghaidi
c02c929c56
Minor comment adjustments
2024-12-02 11:10:25 -08:00
Bassem Dghaidi
c649df4b94
Minor comment adjustments
2024-12-02 10:55:33 -08:00
Bassem Dghaidi
fb40492b6f
Merge branch 'enhance-blob-client' of github.com:actions/toolkit into enhance-blob-client
2024-12-02 10:55:00 -08:00
Bassem Dghaidi
502e8ce651
Minor comment adjustments
2024-12-02 10:53:29 -08:00
Bassem Dghaidi
3f7df8ec5a
Fix comments
...
Co-authored-by: Josh Gross <joshmgross@github.com>
2024-12-02 19:46:18 +01:00
Bassem Dghaidi
b24632bd80
Fix comments
...
Co-authored-by: Josh Gross <joshmgross@github.com>
2024-12-02 19:46:11 +01:00
Bassem Dghaidi
792ec716de
Tune upload options
2024-12-02 07:32:33 -08:00
Bassem Dghaidi
7ad18fd6bd
Fix linter complaints
2024-12-02 04:24:17 -08:00
Bassem Dghaidi
87171e29ca
Fix tests
2024-12-02 04:18:46 -08:00
Bassem Dghaidi
a762876d6d
Minor refactoring
2024-12-02 04:08:21 -08:00
Bassem Dghaidi
d89855bb90
Fix upload progress bug
2024-12-02 03:55:57 -08:00
Bassem Dghaidi
db1d01308c
Troubleshoot
2024-12-02 03:35:20 -08:00
Bassem Dghaidi
4a272e9053
Troubleshoot
2024-12-02 03:08:05 -08:00
Bassem Dghaidi
ee1c07d0aa
Add error handling for failed uploads
2024-12-02 02:38:51 -08:00
Bassem Dghaidi
c6f1224d30
Add progress tracking for blob uploads
2024-12-02 02:33:27 -08:00
Bassem Dghaidi
1d403c2fd8
Fix tests
2024-11-29 07:36:51 -08:00
Bassem Dghaidi
65892d5ffe
Fine tune blob uploads
2024-11-29 07:09:05 -08:00
Bassem Dghaidi
8c5f6f2dc5
Force use of Azure for restoreCacheV2
2024-11-28 07:42:07 -08:00
Bassem Dghaidi
62f5f1885b
Refactor saveCacheV2 to use saveCache from cacheHttpClient
2024-11-28 07:22:01 -08:00
Bassem Dghaidi
eaf0083ee2
Respect download options for restore
2024-11-28 04:56:37 -08:00
Bassem Dghaidi
c1fb081674
Linter fixes
2024-11-28 03:53:34 -08:00
Bassem Dghaidi
df166709a3
Refactor cache upload functionality and improve test cases
2024-11-28 03:52:09 -08:00
Bassem Dghaidi
c5a5de05f6
Delete download-cache
2024-11-28 03:36:32 -08:00
Bassem Dghaidi
35d87ab129
Refactor code formatting for consistency and readability
2024-11-27 05:58:22 -08:00
Bassem Dghaidi
af3981c955
Update the useragent of the old http client to pass cache version
2024-11-27 05:50:01 -08:00
Bassem Dghaidi
27e5cf2514
Replace downloadCacheFile with downloadCacheStorageSDK
2024-11-27 04:51:21 -08:00
John Sudol
b050504b2d
Add test case for when the uploadFile fails on the blobclient
2024-11-27 01:45:46 +00:00
John Sudol
5d0a4af70a
Remove unused mock
2024-11-26 23:33:19 +00:00
John Sudol
94f18eb26e
Only mock the cacheUtil methods we need
2024-11-26 23:05:11 +00:00
John Sudol
208dbe2131
PR feedback
2024-11-26 16:36:12 +00:00
John Sudol
46174ed573
run prettier
2024-11-26 00:56:07 +00:00
John Sudol
1f087496ca
Add debug message for uploadResponse
2024-11-26 00:43:37 +00:00
John Sudol
8f606682c2
Add saveCacheV2 tests
2024-11-26 00:23:42 +00:00
Bassem Dghaidi
35ede8fcf0
Add a new debug message for downloads
2024-11-25 12:08:07 -08:00