public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

Merge pull request #3725 from alcohol/stricter-composer-schema 

composer-schema strict check for minimum-stability, closes #3723
pull/3726/head
Jordi Boggiano 2015-02-10 12:20:43 +00:00
parent 6c971c3028 d02eb8760b
commit 020e1c2143
2 changed files with 92 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
res/composer-schema.json
View File

@ -284,7 +284,8 @@
},
"minimum-stability": {
"type": ["string"],
"description": "The minimum stability the packages must have to be install-able. Possible values are: dev, alpha, beta, RC, stable."
"description": "The minimum stability the packages must have to be install-able. Possible values are: dev, alpha, beta, RC, stable.",
"pattern": "^dev|alpha|beta|rc|RC|stable$"
},
"prefer-stable": {
"type": ["boolean"],

90
tests/Composer/Test/Json/ComposerSchemaTest.php Normal file
View File

@ -0,0 +1,90 @@
<?php
/*
* This file is part of Composer.
*
* (c) Nils Adermann <naderman@naderman.de>
* Jordi Boggiano <j.boggiano@seld.be>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Composer\Test\Json;
use JsonSchema\Validator;
/**
* @author Rob Bast <rob.bast@gmail.com>
*/
class ComposerSchemaTest extends \PHPUnit_Framework_TestCase
{
public function testRequiredProperties()
{
$json = '{ }';
$this->assertEquals(array(
array('property' => '', 'message' => 'the property name is required'),
array('property' => '', 'message' => 'the property description is required'),
), $this->check($json));
$json = '{ "name": "vendor/package" }';
$this->assertEquals(array(
array('property' => '', 'message' => 'the property description is required'),
), $this->check($json));
$json = '{ "description": "generic description" }';
$this->assertEquals(array(
array('property' => '', 'message' => 'the property name is required'),
), $this->check($json));
}
public function testMinimumStabilityValues()
{
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "" }';
$this->assertEquals(array(
array(
'property' => 'minimum-stability',
'message' => 'does not match the regex pattern ^dev|alpha|beta|rc|RC|stable$'
),
), $this->check($json), 'empty string');
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "dummy" }';
$this->assertEquals(array(
array(
'property' => 'minimum-stability',
'message' => 'does not match the regex pattern ^dev|alpha|beta|rc|RC|stable$'
),
), $this->check($json), 'dummy');
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "dev" }';
$this->assertTrue($this->check($json), 'dev');
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "alpha" }';
$this->assertTrue($this->check($json), 'alpha');
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "beta" }';
$this->assertTrue($this->check($json), 'beta');
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "rc" }';
$this->assertTrue($this->check($json), 'rc lowercase');
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "RC" }';
$this->assertTrue($this->check($json), 'rc uppercase');
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "stable" }';
$this->assertTrue($this->check($json), 'stable');
}
private function check($json)
{
$schema = json_decode(file_get_contents(__DIR__ . '/../../../../res/composer-schema.json'));
$validator = new Validator();
$validator->check(json_decode($json), $schema);
if (!$validator->isValid()) {
return $validator->getErrors();
}
return true;
}
}