Make test less brittle
Shouldn't really care about whether the IO is touched. That's the test knowing too much about the implementation.pull/1186/head
parent
88650f9333
commit
06eb4027a7
|
@ -65,12 +65,11 @@ class EventDispatcherTest extends TestCase
|
||||||
|
|
||||||
public function testDispatcherCanExecuteCliAndPhpInSameEventScriptStack()
|
public function testDispatcherCanExecuteCliAndPhpInSameEventScriptStack()
|
||||||
{
|
{
|
||||||
$io = $this->getMock('Composer\IO\IOInterface');
|
|
||||||
$process = $this->getMock('Composer\Util\ProcessExecutor');
|
$process = $this->getMock('Composer\Util\ProcessExecutor');
|
||||||
$dispatcher = $this->getMockBuilder('Composer\Script\EventDispatcher')
|
$dispatcher = $this->getMockBuilder('Composer\Script\EventDispatcher')
|
||||||
->setConstructorArgs(array(
|
->setConstructorArgs(array(
|
||||||
$this->getMock('Composer\Composer'),
|
$this->getMock('Composer\Composer'),
|
||||||
$io,
|
$this->getMock('Composer\IO\IOInterface'),
|
||||||
$process,
|
$process,
|
||||||
))
|
))
|
||||||
->setMethods(array(
|
->setMethods(array(
|
||||||
|
@ -79,8 +78,6 @@ class EventDispatcherTest extends TestCase
|
||||||
))
|
))
|
||||||
->getMock();
|
->getMock();
|
||||||
|
|
||||||
$io->expects($this->never())
|
|
||||||
->method('write');
|
|
||||||
$process->expects($this->exactly(2))
|
$process->expects($this->exactly(2))
|
||||||
->method('execute');
|
->method('execute');
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue