From 0c5bd559f27a90facb077c849558a27f1f74d03f Mon Sep 17 00:00:00 2001 From: Fabian Grutschus Date: Mon, 14 Oct 2013 17:25:57 +0200 Subject: [PATCH] Changes comparsion to strict and removed a comment --- src/Composer/Util/Perforce.php | 2 +- tests/Composer/Test/Util/PerforceTest.php | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Composer/Util/Perforce.php b/src/Composer/Util/Perforce.php index 663f58be3..2ae771345 100644 --- a/src/Composer/Util/Perforce.php +++ b/src/Composer/Util/Perforce.php @@ -370,7 +370,7 @@ class Perforce $result = ''; $exitCode = $processExecutor->execute('p4 -p ' . $url . ' info -s', $result); - return false === strpos($result, 'error') && 0 == $exitCode; + return false === strpos($result, 'error') && 0 === $exitCode; } public function getComposerInformation($identifier) diff --git a/tests/Composer/Test/Util/PerforceTest.php b/tests/Composer/Test/Util/PerforceTest.php index 517c85a75..ffd0ab321 100644 --- a/tests/Composer/Test/Util/PerforceTest.php +++ b/tests/Composer/Test/Util/PerforceTest.php @@ -646,7 +646,6 @@ class PerforceTest extends \PHPUnit_Framework_TestCase $expectedCommand = 'p4 -p perforce.does.exist:port info -s'; $processExecutor->expects($this->at(0)) ->method('execute') - //->with($this->equalTo($expectedCommand), $this->equalTo(null)) ->will($this->returnValue(127)); $result = $this->perforce->checkServerExists('perforce.does.exist:port', $processExecutor);