1
0
Fork 0

Register plugin only one time when it's present in global and project mode

pull/3142/head
François Pluchino 2014-07-21 15:07:27 +02:00
parent cec1627acf
commit 11b945046f
2 changed files with 23 additions and 0 deletions

View File

@ -37,6 +37,7 @@ class PluginManager
protected $versionParser; protected $versionParser;
protected $plugins = array(); protected $plugins = array();
protected $registeredPlugins = array();
private static $classCounter = 0; private static $classCounter = 0;
@ -191,6 +192,10 @@ class PluginManager
{ {
$oldInstallerPlugin = ($package->getType() === 'composer-installer'); $oldInstallerPlugin = ($package->getType() === 'composer-installer');
if (in_array($package->getName(), $this->registeredPlugins)) {
return;
}
$extra = $package->getExtra(); $extra = $package->getExtra();
if (empty($extra['class'])) { if (empty($extra['class'])) {
throw new \UnexpectedValueException('Error while installing '.$package->getPrettyName().', composer-plugin packages should have a class defined in their extra key to be usable.'); throw new \UnexpectedValueException('Error while installing '.$package->getPrettyName().', composer-plugin packages should have a class defined in their extra key to be usable.');
@ -233,6 +238,7 @@ class PluginManager
} else { } else {
$plugin = new $class(); $plugin = new $class();
$this->addPlugin($plugin); $this->addPlugin($plugin);
$this->registeredPlugins[] = $package->getName();
} }
} }
} }

View File

@ -164,4 +164,21 @@ class PluginInstallerTest extends \PHPUnit_Framework_TestCase
$plugins = $this->pm->getPlugins(); $plugins = $this->pm->getPlugins();
$this->assertEquals('installer-v3', $plugins[1]->version); $this->assertEquals('installer-v3', $plugins[1]->version);
} }
public function testRegisterPluginOnlyOneTime()
{
$this->repository
->expects($this->exactly(2))
->method('getPackages')
->will($this->returnValue(array()));
$installer = new PluginInstaller($this->io, $this->composer);
$this->pm->loadInstalledPlugins();
$installer->install($this->repository, $this->packages[0]);
$installer->install($this->repository, clone $this->packages[0]);
$plugins = $this->pm->getPlugins();
$this->assertCount(1, $plugins);
$this->assertEquals('installer-v1', $plugins[0]->version);
}
} }