1
0
Fork 0

LocalChanges for ArchiveFiles

pull/7191/head
Hector Prats 2018-03-14 17:38:12 +01:00
parent 08f769220a
commit 2413b55c60
5 changed files with 176 additions and 9 deletions

View File

@ -12,6 +12,7 @@
namespace Composer\Command; namespace Composer\Command;
use Composer\Downloader\DownloaderInterface;
use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface; use Symfony\Component\Console\Output\OutputInterface;
@ -44,7 +45,8 @@ class StatusCommand extends BaseCommand
->setDefinition(array( ->setDefinition(array(
new InputOption('verbose', 'v|vv|vvv', InputOption::VALUE_NONE, 'Show modified files for each directory that contains changes.'), new InputOption('verbose', 'v|vv|vvv', InputOption::VALUE_NONE, 'Show modified files for each directory that contains changes.'),
)) ))
->setHelp(<<<EOT ->setHelp(
<<<EOT
The status command displays a list of dependencies that have The status command displays a list of dependencies that have
been modified locally. been modified locally.
@ -91,9 +93,7 @@ EOT
if ($changes = $downloader->getLocalChanges($package, $targetDir)) { if ($changes = $downloader->getLocalChanges($package, $targetDir)) {
$errors[$targetDir] = $changes; $errors[$targetDir] = $changes;
} }
} } elseif ($downloader instanceof VcsCapableDownloaderInterface) {
if ($downloader instanceof VcsCapableDownloaderInterface) {
if ($currentRef = $downloader->getVcsReference($package, $targetDir)) { if ($currentRef = $downloader->getVcsReference($package, $targetDir)) {
switch ($package->getInstallationSource()) { switch ($package->getInstallationSource()) {
case 'source': case 'source':
@ -121,12 +121,14 @@ EOT
); );
} }
} }
} } elseif ($downloader instanceof DvcsDownloaderInterface) {
if ($downloader instanceof DvcsDownloaderInterface) {
if ($unpushed = $downloader->getUnpushedChanges($package, $targetDir)) { if ($unpushed = $downloader->getUnpushedChanges($package, $targetDir)) {
$unpushedChanges[$targetDir] = $unpushed; $unpushedChanges[$targetDir] = $unpushed;
} }
} elseif ($downloader instanceof DownloaderInterface) {
if ($changes = $downloader->getLocalChanges($package, $targetDir)) {
$errors[$targetDir] = $changes;
}
} }
} }

View File

@ -27,6 +27,8 @@ abstract class ArchiveDownloader extends FileDownloader
{ {
/** /**
* {@inheritDoc} * {@inheritDoc}
* @throws \RuntimeException
* @throws \UnexpectedValueException
*/ */
public function download(PackageInterface $package, $path, $output = true) public function download(PackageInterface $package, $path, $output = true)
{ {
@ -35,7 +37,9 @@ abstract class ArchiveDownloader extends FileDownloader
while ($retries--) { while ($retries--) {
$fileName = parent::download($package, $path, $output); $fileName = parent::download($package, $path, $output);
if ($output) {
$this->io->writeError(' Extracting archive', false, IOInterface::VERBOSE); $this->io->writeError(' Extracting archive', false, IOInterface::VERBOSE);
}
try { try {
$this->filesystem->ensureDirectoryExists($temporaryDir); $this->filesystem->ensureDirectoryExists($temporaryDir);

View File

@ -61,4 +61,13 @@ interface DownloaderInterface
* @return DownloaderInterface * @return DownloaderInterface
*/ */
public function setOutputProgress($outputProgress); public function setOutputProgress($outputProgress);
/**
* Checks for changes to the local copy
*
* @param PackageInterface $package package instance
* @param string $path package directory
* @return string|null changes or null
*/
public function getLocalChanges(PackageInterface $package, $path);
} }

View File

@ -16,6 +16,7 @@ use Composer\Config;
use Composer\Cache; use Composer\Cache;
use Composer\Factory; use Composer\Factory;
use Composer\IO\IOInterface; use Composer\IO\IOInterface;
use Composer\Package\Comparer\Comparer;
use Composer\Package\PackageInterface; use Composer\Package\PackageInterface;
use Composer\Plugin\PluginEvents; use Composer\Plugin\PluginEvents;
use Composer\Plugin\PreFileDownloadEvent; use Composer\Plugin\PreFileDownloadEvent;
@ -166,8 +167,10 @@ class FileDownloader implements DownloaderInterface
$this->cache->copyFrom($cacheKey, $fileName); $this->cache->copyFrom($cacheKey, $fileName);
} }
} else { } else {
if (!$this->outputProgress) {
$this->io->writeError('Loading from cache', false); $this->io->writeError('Loading from cache', false);
} }
}
if (!file_exists($fileName)) { if (!file_exists($fileName)) {
throw new \UnexpectedValueException($url.' could not be saved to '.$fileName.', make sure the' throw new \UnexpectedValueException($url.' could not be saved to '.$fileName.', make sure the'
@ -278,4 +281,25 @@ class FileDownloader implements DownloaderInterface
return $package->getName().'/'.$cacheKey.'.'.$package->getDistType(); return $package->getName().'/'.$cacheKey.'.'.$package->getDistType();
} }
/**
* {@inheritDoc}
* @throws \RuntimeException
*/
public function getLocalChanges(PackageInterface $package, $targetDir)
{
if ($this->outputProgress) {
$this->io->writeError(' - Installing Original <info>' . $package->getName() . '</info> (<comment>' . $package->getFullPrettyVersion() . '</comment>) and Checking: ', true);
}
$this->download($package, $targetDir.'_compare', false);
$comparer = new Comparer();
$comparer->setSource($targetDir.'_compare');
$comparer->setUpdate($targetDir);
$comparer->doCompare();
$output = $comparer->getChanged(true, true);
$this->filesystem->removeDirectory($targetDir.'_compare');
return trim($output);
}
} }

View File

@ -0,0 +1,128 @@
<?php
/*
* This file is part of Composer.
*
* (c) Nils Adermann <naderman@naderman.de>
* Jordi Boggiano <j.boggiano@seld.be>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Composer\Package\Comparer;
/**
* class Comparer
*
* @author Hector Prats <hectorpratsortega@gmail.com>
*/
class Comparer
{
private $source;
private $update;
private $changed;
public function setSource($source)
{
$this->source = $source;
}
public function setUpdate($update)
{
$this->update = $update;
}
public function getChanged($toString = false, $explicated = false)
{
$changed = $this->changed;
if (!count($changed)) {
return false;
}
if ($explicated) {
foreach ($changed as $sectionKey => $itemSection) {
foreach ($itemSection as $itemKey => $item) {
$changed[$sectionKey][$itemKey] = $item.' ('.$sectionKey.')';
}
}
}
if ($toString) {
foreach ($changed as $sectionKey => $itemSection) {
foreach ($itemSection as $itemKey => $item) {
$changed['string'][] = $item."\r\n";
}
}
$changed = implode("\r\n", $changed['string']);
}
return $changed;
}
public function doCompare()
{
$source = array();
$destination = array();
$this->changed = array();
$currentDirectory = getcwd();
chdir($this->source);
$source = $this->doTree('.', $source);
if (!is_array($source)) {
return;
}
chdir($this->update);
$destination = $this->doTree('.', $destination);
if (!is_array($destination)) {
exit;
}
chdir($currentDirectory);
foreach ($source as $dir => $value) {
foreach ($value as $file => $hash) {
if (isset($destination[$dir][$file])) {
if ($hash !== $destination[$dir][$file]) {
$this->changed['changed'][] = $dir.'/'.$file;
}
} else {
$this->changed['removed'][] = $dir.'/'.$file;
}
}
}
foreach ($destination as $dir => $value) {
foreach ($value as $file => $hash) {
if (!isset($source[$dir][$file])) {
$this->changed['added'][] = $dir.'/'.$file;
}
}
}
}
private function doTree($dir, &$array)
{
if ($dh = opendir($dir)) {
while ($file = readdir($dh)) {
if ($file !== '.' && $file !== '..') {
if (is_dir($dir.'/'.$file)) {
if (!count($array)) {
$array[0] = 'Temp';
}
if (!$this->doTree($dir.'/'.$file, $array)) {
return false;
}
} else {
if (filesize($dir.'/'.$file)) {
set_time_limit(30);
$array[$dir][$file] = md5_file($dir.'/'.$file);
}
}
}
}
if (count($array) > 1 && isset($array['0'])) {
unset($array['0']);
}
return $array;
}
return false;
}
}