Alternative fix for #9941 to avoid code duplication
parent
cbd1e3c2af
commit
288e19153d
|
@ -109,25 +109,13 @@ class Url
|
|||
// e.g. https://api.github.com/repositories/9999999999?access_token=github_token
|
||||
$url = preg_replace('{([&?]access_token=)[^&]+}', '$1***', $url);
|
||||
|
||||
// duplication here to apparent PCRE regression in v10.37 26-May-2021 which
|
||||
// makes (?P<prefix>://|^) not match anymore
|
||||
// should be reverted ideally when fixed in upstream
|
||||
$url = preg_replace_callback('{^(?P<user>[^:/\s@]+):(?P<password>[^@\s/]+)@}i', function ($m) {
|
||||
$url = preg_replace_callback('{^(?P<prefix>[a-z0-9]+://)?(?P<user>[^:/\s@]+):(?P<password>[^@\s/]+)@}i', function ($m) {
|
||||
// if the username looks like a long (12char+) hex string, or a modern github token (e.g. gp1_xxx) we obfuscate that
|
||||
if (preg_match('{^([a-f0-9]{12,}|g[a-z]\d_[a-zA-Z0-9_]+)$}', $m['user'])) {
|
||||
return '***:***@';
|
||||
return $m['prefix'].'***:***@';
|
||||
}
|
||||
|
||||
return $m['user'].':***@';
|
||||
}, $url);
|
||||
|
||||
$url = preg_replace_callback('{://(?P<user>[^:/\s@]+):(?P<password>[^@\s/]+)@}i', function ($m) {
|
||||
// if the username looks like a long (12char+) hex string, or a modern github token (e.g. gp1_xxx) we obfuscate that
|
||||
if (preg_match('{^([a-f0-9]{12,}|g[a-z]\d_[a-zA-Z0-9_]+)$}', $m['user'])) {
|
||||
return '://***:***@';
|
||||
}
|
||||
|
||||
return '://'.$m['user'].':***@';
|
||||
return $m['prefix'].$m['user'].':***@';
|
||||
}, $url);
|
||||
|
||||
return $url;
|
||||
|
|
Loading…
Reference in New Issue