public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

Merge pull request #5343 from localheinz/fix/unstable 

Fix: Do not suggest to avoid exact version constraints for unstable package
pull/5360/head
Jordi Boggiano 2016-05-17 12:04:22 +01:00
parent 206c3c52e0 bb0fb0eb26
commit 32c3429c30
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Composer/Package/Loader/ValidatingArrayLoader.php
View File

@ -151,6 +151,7 @@ class ValidatingArrayLoader implements LoaderInterface
} }
$unboundConstraint = new Constraint('=', $this->versionParser->normalize('dev-master')); $unboundConstraint = new Constraint('=', $this->versionParser->normalize('dev-master'));
$stableConstraint = new Constraint('=', '1.0.0');
foreach (array_keys(BasePackage::$supportedLinkTypes) as $linkType) { foreach (array_keys(BasePackage::$supportedLinkTypes) as $linkType) {
if ($this->validateArray($linkType) && isset($this->config[$linkType])) { if ($this->validateArray($linkType) && isset($this->config[$linkType])) {
@ -183,6 +184,7 @@ class ValidatingArrayLoader implements LoaderInterface
($this->flags & self::CHECK_STRICT_CONSTRAINTS) ($this->flags & self::CHECK_STRICT_CONSTRAINTS)
&& 'require' === $linkType && 'require' === $linkType
&& substr($linkConstraint, 0, 1) === '=' && substr($linkConstraint, 0, 1) === '='
&& $stableConstraint->versionCompare($stableConstraint, $linkConstraint, '<=')
) { ) {
$this->warnings[] = $linkType.'.'.$package.' : exact version constraints ('.$constraint.') should be avoided if the package follows semantic versioning'; $this->warnings[] = $linkType.'.'.$package.' : exact version constraints ('.$constraint.') should be avoided if the package follows semantic versioning';
} }

12
tests/Composer/Test/Package/Loader/ValidatingArrayLoaderTest.php
View File

@ -326,6 +326,18 @@ class ValidatingArrayLoaderTest extends \PHPUnit_Framework_TestCase
), ),
false, false,
), ),
array(
array(
'name' => 'foo/bar',
'require' => array(
'bar/unstable' => '0.3.0',
),
),
array(
// using an exact version constraint for an unstable version should not trigger a warning
),
false,
),
array( array(
array( array(
'name' => 'foo/bar', 'name' => 'foo/bar',