diff --git a/src/Composer/Repository/Vcs/BitbucketDriver.php b/src/Composer/Repository/Vcs/BitbucketDriver.php index e2497aa72..ba1851f53 100644 --- a/src/Composer/Repository/Vcs/BitbucketDriver.php +++ b/src/Composer/Repository/Vcs/BitbucketDriver.php @@ -77,7 +77,7 @@ abstract class BitbucketDriver extends VcsDriver * Attempts to fetch the repository data via the BitBucket API and * sets some parameters which are used in other methods * - * @return void + * @return bool */ protected function getRepoData() { @@ -94,7 +94,7 @@ abstract class BitbucketDriver extends VcsDriver $repoData = JsonFile::parseJson($this->getContentsWithOAuthCredentials($resource, true), $resource); if ($this->fallbackDriver) { - throw new BitbucketFallbackException(); + return false; } $this->parseCloneUrls($repoData['links']['clone']); @@ -104,6 +104,7 @@ abstract class BitbucketDriver extends VcsDriver $this->homeUrl = $repoData['links']['html']['href']; $this->website = $repoData['website']; $this->vcsType = $repoData['scm']; + return true; } /** diff --git a/src/Composer/Repository/Vcs/BitbucketFallbackException.php b/src/Composer/Repository/Vcs/BitbucketFallbackException.php deleted file mode 100644 index 063bb4c10..000000000 --- a/src/Composer/Repository/Vcs/BitbucketFallbackException.php +++ /dev/null @@ -1,17 +0,0 @@ - - * Jordi Boggiano - * - * For the full copyright and license information, please view the LICENSE - * file that was distributed with this source code. - */ - -namespace Composer\Repository\Vcs; - -class BitbucketFallbackException extends \RuntimeException -{ -} diff --git a/src/Composer/Repository/Vcs/GitBitbucketDriver.php b/src/Composer/Repository/Vcs/GitBitbucketDriver.php index 82fe69028..c8a5c9905 100644 --- a/src/Composer/Repository/Vcs/GitBitbucketDriver.php +++ b/src/Composer/Repository/Vcs/GitBitbucketDriver.php @@ -30,9 +30,7 @@ class GitBitbucketDriver extends BitbucketDriver } if (null === $this->rootIdentifier) { - try { - $this->getRepoData(); - } catch (BitbucketFallbackException $e) { + if (! $this->getRepoData()) { return $this->fallbackDriver->getRootIdentifier(); } diff --git a/src/Composer/Repository/Vcs/HgBitbucketDriver.php b/src/Composer/Repository/Vcs/HgBitbucketDriver.php index e908f9ce6..8324f22ac 100644 --- a/src/Composer/Repository/Vcs/HgBitbucketDriver.php +++ b/src/Composer/Repository/Vcs/HgBitbucketDriver.php @@ -30,9 +30,7 @@ class HgBitbucketDriver extends BitbucketDriver } if (null === $this->rootIdentifier) { - try { - $this->getRepoData(); - } catch (BitbucketFallbackException $e) { + if (! $this->getRepoData()) { return $this->fallbackDriver->getRootIdentifier(); }