public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

don't suggest packages already installed

pull/4177/head
Rob Bast 2015-06-24 11:06:21 +02:00
parent adc3e3a7f2
commit 3dffdc8705
1 changed files with 33 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
src/Composer/Command/SuggestsCommand.php
View File

@ -45,38 +45,54 @@ EOT
throw new \RuntimeException('Lockfile seems to be empty?'); throw new \RuntimeException('Lockfile seems to be empty?');
} }
$io = $this->getIO(); $packages = $lock['packages'];
$list = $lock['packages'];
if (!$input->getOption('no-dev')) { if (!$input->getOption('no-dev')) {
$list += $lock['packages-dev']; $packages += $lock['packages-dev'];
} }
$packages = $input->getArgument('packages'); $filter = $input->getArgument('packages');
foreach ($list as $package) { foreach ($packages as $package) {
if (!empty($package['suggest']) && (empty($packages) || in_array($package['name'], $packages))) { if (empty($package['suggest'])) {
$this->printSuggestions($package['name'], $package['suggest']); continue;
} }
if (!empty($filter) && !in_array($package['name'], $filter)) {
continue;
}
$this->printSuggestions($packages, $package['name'], $package['suggest']);
} }
} }
protected function printSuggestions($name, $suggests) protected function printSuggestions($installed, $source, $suggestions)
{ {
$io = $this->getIO(); foreach ($suggestions as $suggestion => $reason) {
foreach ($installed as $package) {
if ($package['name'] === $suggestion) {
continue 2;
}
}
foreach ($suggests as $target => $reason) {
if (empty($reason)) { if (empty($reason)) {
$reason = '*'; $reason = '*';
} }
if ($io->isVeryVerbose()) { $this->printSuggestion($source, $suggestion, $reason);
$io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>: %s', $name, $target, $reason)); }
} elseif ($io->isVerbose()) { }
$io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>', $name, $target));
} else { protected function printSuggestion($package, $suggestion, $reason)
$io->write(sprintf('<info>%s</info>', $target)); {
} $io = $this->getIO();
if ($io->isVeryVerbose()) {
$io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>: %s', $package, $suggestion, $reason));
} elseif ($io->isVerbose()) {
$io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>', $package, $suggestion));
} else {
$io->write(sprintf('<info>%s</info>', $suggestion));
} }
} }
} }