mirror of
https://github.com/composer/composer
synced 2025-05-09 00:22:53 +00:00
Implement changes after review by stof.
- Use camelCase variable names. - Set 3rd argument of http_build_query - Remove obsolete checks
This commit is contained in:
parent
5dbdefdd72
commit
4377ba2bcb
5 changed files with 19 additions and 15 deletions
|
@ -86,7 +86,9 @@ abstract class BitbucketDriver extends VcsDriver
|
|||
$this->owner,
|
||||
$this->repository,
|
||||
http_build_query(
|
||||
array('fields' => '-project,-owner')
|
||||
array('fields' => '-project,-owner'),
|
||||
null,
|
||||
'&'
|
||||
)
|
||||
);
|
||||
|
||||
|
@ -266,7 +268,9 @@ abstract class BitbucketDriver extends VcsDriver
|
|||
'pagelen' => 100,
|
||||
'fields' => 'values.name,values.target.hash,next',
|
||||
'sort' => '-target.date'
|
||||
)
|
||||
),
|
||||
null,
|
||||
'&'
|
||||
)
|
||||
);
|
||||
$hasNext = true;
|
||||
|
@ -308,7 +312,9 @@ abstract class BitbucketDriver extends VcsDriver
|
|||
'pagelen' => 100,
|
||||
'fields' => 'values.name,values.target.hash,next',
|
||||
'sort' => '-target.date'
|
||||
)
|
||||
),
|
||||
null,
|
||||
'&'
|
||||
)
|
||||
);
|
||||
$hasNext = true;
|
||||
|
|
|
@ -43,8 +43,8 @@ class GitBitbucketDriver extends BitbucketDriver
|
|||
);
|
||||
}
|
||||
|
||||
$main_branch_data = $this->getMainBranchData();
|
||||
$this->rootIdentifier = !empty($main_branch_data['name']) ? $main_branch_data['name'] : 'master';
|
||||
$mainBranchData = $this->getMainBranchData();
|
||||
$this->rootIdentifier = !empty($mainBranchData['name']) ? $mainBranchData['name'] : 'master';
|
||||
}
|
||||
|
||||
return $this->rootIdentifier;
|
||||
|
|
|
@ -43,8 +43,8 @@ class HgBitbucketDriver extends BitbucketDriver
|
|||
);
|
||||
}
|
||||
|
||||
$main_branch_data = $this->getMainBranchData();
|
||||
$this->rootIdentifier = !empty($main_branch_data['name']) ? $main_branch_data['name'] : 'default';
|
||||
$mainBranchData = $this->getMainBranchData();
|
||||
$this->rootIdentifier = !empty($mainBranchData['name']) ? $mainBranchData['name'] : 'default';
|
||||
}
|
||||
|
||||
return $this->rootIdentifier;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue