From 44634a689d7342c4814885af888955e4f507bcab Mon Sep 17 00:00:00 2001 From: Rafael Kassner Date: Mon, 3 Oct 2016 13:17:07 +0200 Subject: [PATCH] HgDriver does not identify bitbucket mercurial repos correctly --- src/Composer/Repository/Vcs/HgDriver.php | 2 +- .../Test/Repository/Vcs/HgDriverTest.php | 63 +++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-) create mode 100644 tests/Composer/Test/Repository/Vcs/HgDriverTest.php diff --git a/src/Composer/Repository/Vcs/HgDriver.php b/src/Composer/Repository/Vcs/HgDriver.php index c82c8c4aa..4dc103d38 100644 --- a/src/Composer/Repository/Vcs/HgDriver.php +++ b/src/Composer/Repository/Vcs/HgDriver.php @@ -195,7 +195,7 @@ class HgDriver extends VcsDriver */ public static function supports(IOInterface $io, Config $config, $url, $deep = false) { - if (preg_match('#(^(?:https?|ssh)://(?:[^@]@)?bitbucket.org|https://(?:.*?)\.kilnhg.com)#i', $url)) { + if (preg_match('#(^(?:https?|ssh)://(?:[^@]+@)?bitbucket.org|https://(?:.*?)\.kilnhg.com)#i', $url)) { return true; } diff --git a/tests/Composer/Test/Repository/Vcs/HgDriverTest.php b/tests/Composer/Test/Repository/Vcs/HgDriverTest.php new file mode 100644 index 000000000..3b62ac317 --- /dev/null +++ b/tests/Composer/Test/Repository/Vcs/HgDriverTest.php @@ -0,0 +1,63 @@ + + * Jordi Boggiano + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Composer\Test\Repository\Vcs; + +use Composer\Repository\Vcs\HgDriver; +use Composer\TestCase; +use Composer\Util\Filesystem; +use Composer\Config; + +class HgDriverTest extends TestCase +{ + + /** @type \Composer\IO\IOInterface|\PHPUnit_Framework_MockObject_MockObject */ + private $io; + /** @type \Composer\Config */ + private $config; + /** @type string */ + private $home; + + public function setUp() + { + $this->io = $this->getMock('Composer\IO\IOInterface'); + $this->home = $this->getUniqueTmpDirectory(); + $this->config = new Config(); + $this->config->merge(array( + 'config' => array( + 'home' => $this->home, + ), + )); + } + + public function tearDown() + { + $fs = new Filesystem; + $fs->removeDirectory($this->home); + } + + public function testSupports() + { + $this->assertTrue( + HgDriver::supports($this->io, $this->config, 'ssh://bitbucket.org/user/repo') + ); + + $this->assertTrue( + HgDriver::supports($this->io, $this->config, 'ssh://hg@bitbucket.org/user/repo') + ); + + $this->assertTrue( + HgDriver::supports($this->io, $this->config, 'ssh://user@bitbucket.org/user/repo') + ); + } + +}