public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

Ignore self references when anlaysing independent root requirements 

When creating a transaction we try to identify all requirements that are
not themselves required by any other package. If a package references
itself this should not mark it as being required by another package.
pull/4989/head
Nils Adermann 2016-03-02 13:03:26 +01:00
parent 7b404c4717
commit 4af74b54e0
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Composer/DependencyResolver/Transaction.php
View File

@ -165,7 +165,9 @@ class Transaction
$possibleRequires = $this->pool->whatProvides($link->getTarget(), $link->getConstraint());
foreach ($possibleRequires as $require) {
unset($roots[$require->id]);
if ($require !== $package) {
unset($roots[$require->id]);
}
}
}
}

5
tests/Composer/Test/Fixtures/installer/circular-dependency2.test
View File

@ -23,10 +23,7 @@ Circular dependencies are possible between packages
{
"name": "regular/pkg",
"version": "1.0.0",
"source": { "reference": "some.branch", "type": "git", "url": "" },
"__dummy__require": {
"require/itself": "1.0.0"
}
"source": { "reference": "some.branch", "type": "git", "url": "" }
}
]
}