From 4b1e386fffe98d113a1e65b561dcb286dfaba239 Mon Sep 17 00:00:00 2001
From: Jordi Boggiano <j.boggiano@seld.be>
Date: Wed, 6 May 2020 13:23:38 +0200
Subject: [PATCH] Make sure php8 runs tests, and that 7.3 runs complete test
 suite

---
 .github/workflows/continuous-integration.yml |  8 ++++++--
 tests/complete.phpunit.xml                   | 11 +++++++++--
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
index 122d09d63..022fc7fa0 100644
--- a/.github/workflows/continuous-integration.yml
+++ b/.github/workflows/continuous-integration.yml
@@ -114,9 +114,13 @@ jobs:
         run: "echo \"::set-env name=SYMFONY_PHPUNIT_VERSION::7.5\""
 
       - name: "Run tests"
-        if: "matrix.php-version != '8.0'"
+        if: "matrix.php-version != '8.0' && matrix.php-version != '7.3'"
         run: "vendor/bin/simple-phpunit"
 
+      - name: "Run Complete test suite"
+        if: "matrix.php-version == '7.3'"
+        run: "vendor/bin/simple-phpunit --configuration tests/complete.phpunit.xml"
+
       - name: "Run tests for PHP 8"
         if: "matrix.php-version == '8.0'"
-        run: "bin/composer remove --dev symfony/phpunit-bridge --ignore-platform-reqs && bin/composer require phpunit/phpunit:^7.5 --ignore-platform-reqs"
+        run: "bin/composer remove --dev symfony/phpunit-bridge --ignore-platform-reqs && bin/composer require phpunit/phpunit:^7.5 --ignore-platform-reqs && vendor/bin/phpunit"
diff --git a/tests/complete.phpunit.xml b/tests/complete.phpunit.xml
index 0a3f29f06..30faf6837 100644
--- a/tests/complete.phpunit.xml
+++ b/tests/complete.phpunit.xml
@@ -1,16 +1,23 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit backupGlobals="false"
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/5.7/phpunit.xsd"
+         backupGlobals="false"
          backupStaticAttributes="false"
+         beStrictAboutTestsThatDoNotTestAnything="true"
          colors="true"
          convertErrorsToExceptions="true"
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
+         failOnRisky="true"
+         strict="false"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
          bootstrap="./bootstrap.php"
 >
+    <php>
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak"/>
+    </php>
     <testsuites>
         <testsuite name="Full Composer Test Suite">
             <directory>./Composer/</directory>