ConfigValidator: ensure that require-dev exists during override check
- Ensure that require-dev is present before checking for dependeny overrides. - A small grammar update for the warning message.pull/2535/head
parent
09602bbf00
commit
528d35a835
|
@ -108,9 +108,14 @@ class ConfigValidator
|
||||||
$warnings[] = "The package type 'composer-installer' is deprecated. Please distribute your custom installers as plugins from now on. See http://getcomposer.org/doc/articles/plugins.md for plugin documentation.";
|
$warnings[] = "The package type 'composer-installer' is deprecated. Please distribute your custom installers as plugins from now on. See http://getcomposer.org/doc/articles/plugins.md for plugin documentation.";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// check for require-dev overrides
|
||||||
|
if (isset($manifest['require']) && isset($manifest['require-dev'])) {
|
||||||
$requireOverrides = array_intersect_key($manifest['require'], $manifest['require-dev']);
|
$requireOverrides = array_intersect_key($manifest['require'], $manifest['require-dev']);
|
||||||
|
|
||||||
if (!empty($requireOverrides)) {
|
if (!empty($requireOverrides)) {
|
||||||
$warnings[] = implode(', ', array_keys($requireOverrides)). " is required both in require and require-dev, this can lead to unexpected behavior";
|
$plural = (count($requireOverrides) > 1) ? 'are' : 'is';
|
||||||
|
$warnings[] = implode(', ', array_keys($requireOverrides)). " {$plural} required both in require and require-dev, this can lead to unexpected behavior";
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
|
|
Loading…
Reference in New Issue