1
0
Fork 0

Report proper error if a write fails instead of saying the download failed

pull/557/merge
Jordi Boggiano 2012-04-10 09:43:47 +02:00
parent 38cc4e9e5f
commit 5c5f87008f
1 changed files with 7 additions and 4 deletions

View File

@ -130,9 +130,16 @@ class RemoteFilesystem
} }
} }
if ($this->progress) {
$this->io->overwrite(" Downloading: <comment>100%</comment>");
}
// handle copy command if download was successful // handle copy command if download was successful
if (false !== $result && null !== $fileName) { if (false !== $result && null !== $fileName) {
$result = (Boolean) @file_put_contents($fileName, $result); $result = (Boolean) @file_put_contents($fileName, $result);
if (false === $result) {
throw new TransportException('The "'.$fileUrl.'" file could not be written to '.$fileName);
}
} }
// avoid overriding if content was loaded by a sub-call to get() // avoid overriding if content was loaded by a sub-call to get()
@ -140,10 +147,6 @@ class RemoteFilesystem
$this->result = $result; $this->result = $result;
} }
if ($this->progress) {
$this->io->overwrite(" Downloading: <comment>100%</comment>");
}
if (false === $this->result) { if (false === $this->result) {
throw new TransportException('The "'.$fileUrl.'" file could not be downloaded'); throw new TransportException('The "'.$fileUrl.'" file could not be downloaded');
} }