1
0
Fork 0

Fix ApplicationTest interacting with other tests

pull/10769/head
Jordi Boggiano 2022-05-11 16:25:24 +02:00
parent fdab6657c7
commit 6ac4de19d7
No known key found for this signature in database
GPG Key ID: 7BBD42C429EC80BC
2 changed files with 27 additions and 94 deletions

View File

@ -80,6 +80,10 @@ EOT
*/ */
protected function execute(InputInterface $input, OutputInterface $output): int protected function execute(InputInterface $input, OutputInterface $output): int
{ {
if ($_SERVER['argv'][0] === 'Standard input code') {
return 1;
}
// trigger autoloading of a few classes which may be needed when verifying/swapping the phar file // trigger autoloading of a few classes which may be needed when verifying/swapping the phar file
// to ensure we do not try to load them from the new phar, see https://github.com/composer/composer/issues/10252 // to ensure we do not try to load them from the new phar, see https://github.com/composer/composer/issues/10252
class_exists('Composer\Util\Platform'); class_exists('Composer\Util\Platform');

View File

@ -13,7 +13,9 @@
namespace Composer\Test; namespace Composer\Test;
use Composer\Console\Application; use Composer\Console\Application;
use Composer\Util\Platform;
use Composer\XdebugHandler\XdebugHandler; use Composer\XdebugHandler\XdebugHandler;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput; use Symfony\Component\Console\Output\BufferedOutput;
class ApplicationTest extends TestCase class ApplicationTest extends TestCase
@ -22,124 +24,51 @@ class ApplicationTest extends TestCase
{ {
parent::tearDown(); parent::tearDown();
putenv('COMPOSER_NO_INTERACTION'); Platform::clearEnv('COMPOSER_DISABLE_XDEBUG_WARN');
} }
protected function setUp(): void
{
parent::setUp();
Platform::putEnv('COMPOSER_DISABLE_XDEBUG_WARN', '1');
}
/**
* @runInSeparateProcess
* @preserveGlobalState disabled
*/
public function testDevWarning(): void public function testDevWarning(): void
{ {
$application = new Application; $application = new Application;
$inputMock = $this->getMockBuilder('Symfony\Component\Console\Input\InputInterface')->getMock();
$outputMock = $this->getMockBuilder('Symfony\Component\Console\Output\OutputInterface')->getMock();
putenv('COMPOSER_NO_INTERACTION=1');
$inputMock->expects($this->any())
->method('hasParameterOption')
->willReturnCallback(function ($opt): bool {
switch ($opt) {
case '--no-plugins':
return true;
case '--no-scripts':
return false;
case '--no-cache':
return false;
}
return false;
});
$inputMock->expects($this->once())
->method('setInteractive')
->with($this->equalTo(false));
$inputMock->expects($this->once())
->method('getParameterOption')
->with($this->equalTo(array('--working-dir', '-d')), $this->equalTo(null))
->will($this->returnValue(null));
$inputMock->expects($this->any())
->method('getFirstArgument')
->will($this->returnValue('about'));
$output = new BufferedOutput();
$expectedOutput = '';
if (XdebugHandler::isXdebugActive()) {
$expectedOutput .= '<warning>Composer is operating slower than normal because you have Xdebug enabled. See https://getcomposer.org/xdebug</warning>'.PHP_EOL;
}
$expectedOutput .= sprintf('<warning>Warning: This development build of Composer is over 60 days old. It is recommended to update it by running "%s self-update" to get the latest version.</warning>', $_SERVER['PHP_SELF']).PHP_EOL;
if (!defined('COMPOSER_DEV_WARNING_TIME')) { if (!defined('COMPOSER_DEV_WARNING_TIME')) {
define('COMPOSER_DEV_WARNING_TIME', time() - 1); define('COMPOSER_DEV_WARNING_TIME', time() - 1);
} }
$application->doRun($inputMock, $output); $output = new BufferedOutput();
$application->doRun(new ArrayInput(['command' => 'about']), $output);
$expectedOutput = sprintf('<warning>Warning: This development build of Composer is over 60 days old. It is recommended to update it by running "%s self-update" to get the latest version.</warning>', $_SERVER['PHP_SELF']).PHP_EOL;
$this->assertStringContainsString($expectedOutput, $output->fetch()); $this->assertStringContainsString($expectedOutput, $output->fetch());
} }
/** /**
* @param string $command * @runInSeparateProcess
* @return void * @preserveGlobalState disabled
*/ */
public function ensureNoDevWarning(string $command): void public function testDevWarningSuppressedForSelfUpdate(): void
{ {
$application = new Application; $application = new Application;
$application->add(new \Composer\Command\SelfUpdateCommand); $application->add(new \Composer\Command\SelfUpdateCommand);
$inputMock = $this->getMockBuilder('Symfony\Component\Console\Input\InputInterface')->getMock();
$outputMock = $this->getMockBuilder('Symfony\Component\Console\Output\OutputInterface')->getMock();
putenv('COMPOSER_NO_INTERACTION=1');
$inputMock->expects($this->any())
->method('hasParameterOption')
->willReturnCallback(function ($opt): bool {
switch ($opt) {
case '--no-plugins':
return true;
case '--no-scripts':
return false;
case '--no-cache':
return false;
}
return false;
});
$inputMock->expects($this->once())
->method('setInteractive')
->with($this->equalTo(false));
$inputMock->expects($this->once())
->method('getParameterOption')
->with($this->equalTo(array('--working-dir', '-d')), $this->equalTo(null))
->will($this->returnValue(null));
$inputMock->expects($this->any())
->method('getFirstArgument')
->will($this->returnValue('about'));
$outputMock->expects($this->never())
->method("writeln");
if (!defined('COMPOSER_DEV_WARNING_TIME')) { if (!defined('COMPOSER_DEV_WARNING_TIME')) {
define('COMPOSER_DEV_WARNING_TIME', time() - 1); define('COMPOSER_DEV_WARNING_TIME', time() - 1);
} }
$application->doRun($inputMock, $outputMock); $output = new BufferedOutput();
} $application->doRun(new ArrayInput(['command' => 'self-update']), $output);
public function testDevWarningPrevented(): void $this->assertSame('', $output->fetch());
{
$this->ensureNoDevWarning('self-update');
}
public function testDevWarningPreventedAlias(): void
{
$this->ensureNoDevWarning('self-up');
} }
} }