public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

PHP 8.1/LibraryInstallerTest: add missing mock expectation 

The `LibraryInstallerTest::testUninstall()` method mocks a `Package` object, but did not set an expectation for a call to `getName()`, while that method _is_ called in the `LibraryInstaller::uninstall()` method.

Without expectation, the mock returns `null`, which was subsequently being passed on to `strpos()` leading to the below error.

Fixes:
```
Deprecation triggered by Composer\Test\Installer\LibraryInstallerTest::testUninstall:
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 202)
1 src/Composer/Installer/LibraryInstaller.php(202): strpos(NULL, '...')
2 vendor/react/promise/src/FulfilledPromise.php(28): Composer\Installer\LibraryInstaller->Composer\Installer\{closure}(NULL)
3 src/Composer/Installer/LibraryInstaller.php(208): React\Promise\FulfilledPromise->then(Object(Closure))
4 tests/Composer/Test/Installer/LibraryInstallerTest.php(221): Composer\Installer\LibraryInstaller->uninstall(Object(Mock_InstalledRepositoryInterface_e3699f95), Object(Mock_Package_e4571076))
...
```
pull/10055/head
jrfnl 2021-08-05 15:33:09 +02:00
parent c65bd832d6
commit 7004e0d031
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/Composer/Test/Installer/LibraryInstallerTest.php
View File

@ -201,6 +201,10 @@ class LibraryInstallerTest extends TestCase
->expects($this->any()) ->expects($this->any())
->method('getPrettyName') ->method('getPrettyName')
->will($this->returnValue('pkg')); ->will($this->returnValue('pkg'));
$package
->expects($this->any())
->method('getName')
->will($this->returnValue('pkg'));
$this->repository $this->repository
->expects($this->exactly(2)) ->expects($this->exactly(2))