1
0
Fork 0

Merge pull request #6340 from derrabus/remove-control-chars-from-suggest

Remove ANSI control characters from suggested packages output
pull/6364/merge
Jordi Boggiano 2017-04-19 17:49:46 +02:00 committed by GitHub
commit 75416c69b4
2 changed files with 46 additions and 2 deletions

View File

@ -15,6 +15,7 @@ namespace Composer\Installer;
use Composer\IO\IOInterface;
use Composer\Package\PackageInterface;
use Composer\Repository\RepositoryInterface;
use Symfony\Component\Console\Formatter\OutputFormatter;
/**
* Add suggested packages from different places to output them in the end.
@ -116,11 +117,35 @@ class SuggestedPackagesReporter
$this->io->writeError(sprintf(
'%s suggests installing %s (%s)',
$suggestion['source'],
$suggestion['target'],
$suggestion['reason']
$this->escapeOutput($suggestion['target']),
$this->escapeOutput($suggestion['reason'])
));
}
return $this;
}
/**
* @param string $string
* @return string
*/
private function escapeOutput($string)
{
return OutputFormatter::escape(
$this->removeControlCharacters($string)
);
}
/**
* @param string $string
* @return string
*/
private function removeControlCharacters($string)
{
return preg_replace(
'/[[:cntrl:]]/',
'',
str_replace("\n", ' ', $string)
);
}
}

View File

@ -144,6 +144,25 @@ class SuggestedPackagesReporterTest extends \PHPUnit_Framework_TestCase
$this->suggestedPackagesReporter->output();
}
/**
* @covers ::output
*/
public function testOutputIgnoresFormatting()
{
$this->suggestedPackagesReporter->addPackage('source', 'target1', "\x1b[1;37;42m Like us\r\non Facebook \x1b[0m");
$this->suggestedPackagesReporter->addPackage('source', 'target2', "<bg=green>Like us on Facebook</>");
$this->io->expects($this->at(0))
->method('writeError')
->with("source suggests installing target1 ([1;37;42m Like us on Facebook [0m)");
$this->io->expects($this->at(1))
->method('writeError')
->with('source suggests installing target2 (\\<bg=green>Like us on Facebook\\</>)');
$this->suggestedPackagesReporter->output();
}
/**
* @covers ::output
*/