public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

Check headers for missing scopes before asking for new OAuth token 

This patch stops the GitHub VCS driver prompting for a new access
token when a repository is deleted/hidden.

Specifically, it checks the X-OAuth-Scopes and X-Accepted-OAuth-Scopes
response headers to see if the scopes on the current request match
those needed by the API call. If they do, the 404 means that the repo
is deleted/hidden, and there's no point asking for a new OAuth token.
pull/5435/head
Phil Lello 2016-06-14 20:02:00 +01:00
parent 5a3d60c0cf
commit 7a112b0395
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/Composer/Repository/Vcs/GitHubDriver.php
View File

@ -325,7 +325,27 @@ class GitHubDriver extends VcsDriver
return $this->attemptCloneFallback();
}
$gitHubUtil->authorizeOAuthInteractively($this->originUrl, 'Your GitHub credentials are required to fetch private repository metadata (<info>'.$this->url.'</info>)');
$scopes_issued = array();
$scopes_needed = array();
if (!is_null($headers = $e->getHeaders())) {
// Check if X-OAuth-Scopes and X-Accepted-OAuth-Scopes should let us in...
foreach ($headers as $header) {
$k = substr($header, 0, strpos($header, ":"));
$v = trim(substr($header, strpos($header, ":")+1));
switch ($k) {
case 'X-OAuth-Scopes':
$scopes_issued = explode(" ", $v);
break;
case 'X-Accepted-OAuth-Scopes':
$scopes_needed = explode(" ", $v);
break;
}
}
}
$scopes_failed = array_diff($scopes_needed, $scopes_issued);
if (is_null($headers) || count($scopes_failed)) {
$gitHubUtil->authorizeOAuthInteractively($this->originUrl, 'Your GitHub credentials are required to fetch private repository metadata (<info>'.$this->url.'</info>)');
}
return parent::getContents($url);