1
0
Fork 0

added a way to disable custom installers

pull/938/head
Johannes M. Schmitt 2012-07-21 16:51:40 +02:00
parent 6fef956677
commit 88a1f27798
3 changed files with 48 additions and 7 deletions

View File

@ -47,7 +47,8 @@ class CreateProjectCommand extends Command
new InputArgument('version', InputArgument::OPTIONAL, 'Version, will defaults to latest'), new InputArgument('version', InputArgument::OPTIONAL, 'Version, will defaults to latest'),
new InputOption('prefer-source', null, InputOption::VALUE_NONE, 'Forces installation from package sources when possible, including VCS information.'), new InputOption('prefer-source', null, InputOption::VALUE_NONE, 'Forces installation from package sources when possible, including VCS information.'),
new InputOption('repository-url', null, InputOption::VALUE_REQUIRED, 'Pick a different repository url to look for the package.'), new InputOption('repository-url', null, InputOption::VALUE_REQUIRED, 'Pick a different repository url to look for the package.'),
new InputOption('dev', null, InputOption::VALUE_NONE, 'Whether to install dependencies for development.') new InputOption('dev', null, InputOption::VALUE_NONE, 'Whether to install dependencies for development.'),
new InputOption('disable-custom-installers', null, InputOption::VALUE_NONE, 'Whether to disable custom installers.'),
)) ))
->setHelp(<<<EOT ->setHelp(<<<EOT
The <info>create-project</info> command creates a new project from a given The <info>create-project</info> command creates a new project from a given
@ -79,11 +80,12 @@ EOT
$input->getArgument('version'), $input->getArgument('version'),
$input->getOption('prefer-source'), $input->getOption('prefer-source'),
$input->getOption('dev'), $input->getOption('dev'),
$input->getOption('repository-url') $input->getOption('repository-url'),
$input->getOption('disable-custom-installers')
); );
} }
public function installProject(IOInterface $io, $packageName, $directory = null, $version = null, $preferSource = false, $installDevPackages = false, $repositoryUrl = null) public function installProject(IOInterface $io, $packageName, $directory = null, $version = null, $preferSource = false, $installDevPackages = false, $repositoryUrl = null, $disableCustomInstallers = false)
{ {
$dm = $this->createDownloadManager($io); $dm = $this->createDownloadManager($io);
if ($preferSource) { if ($preferSource) {
@ -120,6 +122,11 @@ EOT
} }
$io->write('<info>Installing ' . $package->getName() . ' (' . VersionParser::formatVersion($package, false) . ')</info>', true); $io->write('<info>Installing ' . $package->getName() . ' (' . VersionParser::formatVersion($package, false) . ')</info>', true);
if ($disableCustomInstallers) {
$io->write('<info>Custom installers have been disabled.</info>');
}
if (0 === strpos($package->getPrettyVersion(), 'dev-') && in_array($package->getSourceType(), array('git', 'hg'))) { if (0 === strpos($package->getPrettyVersion(), 'dev-') && in_array($package->getSourceType(), array('git', 'hg'))) {
$package->setSourceReference(substr($package->getPrettyVersion(), 4)); $package->setSourceReference(substr($package->getPrettyVersion(), 4));
} }
@ -138,10 +145,14 @@ EOT
$composer = Factory::create($io); $composer = Factory::create($io);
$installer = Installer::create($io, $composer); $installer = Installer::create($io, $composer);
$installer $installer->setPreferSource($preferSource)
->setPreferSource($preferSource) ->setDevMode($installDevPackages);
->setDevMode($installDevPackages)
->run(); if ($disableCustomInstallers) {
$installer->disableCustomInstallers();
}
$installer->run();
} }
protected function createDownloadManager(IOInterface $io) protected function createDownloadManager(IOInterface $io)

View File

@ -722,4 +722,16 @@ class Installer
return $this; return $this;
} }
/**
* Disables custom installers.
*
* Call this if you want to ensure that third-party code never gets
* executed. The default is to automatically install, and execute
* custom third-party installers.
*/
public function disableCustomInstallers()
{
$this->installationManager->disableCustomInstallers();
}
} }

View File

@ -46,6 +46,24 @@ class InstallationManager
$this->cache = array(); $this->cache = array();
} }
/**
* Disables custom installers.
*
* We prevent any custom installers from being instantiated by simply
* deactivating the installer for them. This ensure that no third-party
* code is ever executed.
*/
public function disableCustomInstallers()
{
foreach ($this->installers as $i => $installer) {
if ( ! $installer instanceof InstallerInstaller) {
continue;
}
unset($this->installers[$i]);
}
}
/** /**
* Returns installer for a specific package type. * Returns installer for a specific package type.
* *