Fix schema minimum-stability pattern
parent
251b852fd2
commit
8d8842eb8c
|
@ -41,7 +41,7 @@ To achieve this, you need to acquire the Composer source code:
|
||||||
2. Download the [`composer.phar`](https://getcomposer.org/composer.phar) executable
|
2. Download the [`composer.phar`](https://getcomposer.org/composer.phar) executable
|
||||||
3. Run Composer to get the dependencies: `cd composer && php ../composer.phar install`
|
3. Run Composer to get the dependencies: `cd composer && php ../composer.phar install`
|
||||||
|
|
||||||
You can run the test suite by executing `vendor/bin/phpunit` when inside the
|
You can run the test suite by executing `vendor/bin/simple-phpunit` when inside the
|
||||||
composer directory, and run Composer by executing the `bin/composer`. To test
|
composer directory, and run Composer by executing the `bin/composer`. To test
|
||||||
your modified Composer code against another project, run `php
|
your modified Composer code against another project, run `php
|
||||||
/path/to/composer/bin/composer` inside that project's directory.
|
/path/to/composer/bin/composer` inside that project's directory.
|
||||||
|
|
|
@ -1,6 +1,6 @@
|
||||||
{
|
{
|
||||||
"$schema": "https://json-schema.org/draft-04/schema#",
|
"$schema": "https://json-schema.org/draft-04/schema#",
|
||||||
"name": "Package",
|
"title": "Package",
|
||||||
"type": "object",
|
"type": "object",
|
||||||
"additionalProperties": false,
|
"additionalProperties": false,
|
||||||
"required": [ "name", "description" ],
|
"required": [ "name", "description" ],
|
||||||
|
@ -42,7 +42,7 @@
|
||||||
"version": {
|
"version": {
|
||||||
"type": "string",
|
"type": "string",
|
||||||
"description": "Package version, see https://getcomposer.org/doc/04-schema.md#version for more info on valid schemes.",
|
"description": "Package version, see https://getcomposer.org/doc/04-schema.md#version for more info on valid schemes.",
|
||||||
"pattern": "^v?\\d+(((\\.\\d+)?\\.\\d+)?\\.\\d+)?|^dev-"
|
"pattern": "^v?\\d+(\\.\\d+){0,3}|^dev-"
|
||||||
},
|
},
|
||||||
"time": {
|
"time": {
|
||||||
"type": "string",
|
"type": "string",
|
||||||
|
@ -397,7 +397,7 @@
|
||||||
"minimum-stability": {
|
"minimum-stability": {
|
||||||
"type": ["string"],
|
"type": ["string"],
|
||||||
"description": "The minimum stability the packages must have to be install-able. Possible values are: dev, alpha, beta, RC, stable.",
|
"description": "The minimum stability the packages must have to be install-able. Possible values are: dev, alpha, beta, RC, stable.",
|
||||||
"pattern": "^dev|alpha|beta|rc|RC|stable$"
|
"enum": ["dev", "alpha", "beta", "rc", "RC", "stable"]
|
||||||
},
|
},
|
||||||
"prefer-stable": {
|
"prefer-stable": {
|
||||||
"type": ["boolean"],
|
"type": ["boolean"],
|
||||||
|
|
|
@ -71,25 +71,23 @@ class ComposerSchemaTest extends TestCase
|
||||||
|
|
||||||
public function testMinimumStabilityValues()
|
public function testMinimumStabilityValues()
|
||||||
{
|
{
|
||||||
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "" }';
|
$expectedError = array(
|
||||||
$this->assertEquals(array(
|
|
||||||
array(
|
array(
|
||||||
'property' => 'minimum-stability',
|
'property' => 'minimum-stability',
|
||||||
'message' => 'Does not match the regex pattern ^dev|alpha|beta|rc|RC|stable$',
|
'message' => 'Does not have a value in the enumeration ["dev","alpha","beta","rc","RC","stable"]',
|
||||||
'constraint' => 'pattern',
|
'constraint' => 'enum',
|
||||||
'pattern' => '^dev|alpha|beta|rc|RC|stable$',
|
'enum' => array('dev', 'alpha', 'beta', 'rc', 'RC', 'stable'),
|
||||||
),
|
),
|
||||||
), $this->check($json), 'empty string');
|
);
|
||||||
|
|
||||||
|
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "" }';
|
||||||
|
$this->assertEquals($expectedError, $this->check($json), 'empty string');
|
||||||
|
|
||||||
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "dummy" }';
|
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "dummy" }';
|
||||||
$this->assertEquals(array(
|
$this->assertEquals($expectedError, $this->check($json), 'dummy');
|
||||||
array(
|
|
||||||
'property' => 'minimum-stability',
|
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "devz" }';
|
||||||
'message' => 'Does not match the regex pattern ^dev|alpha|beta|rc|RC|stable$',
|
$this->assertEquals($expectedError, $this->check($json), 'devz');
|
||||||
'constraint' => 'pattern',
|
|
||||||
'pattern' => '^dev|alpha|beta|rc|RC|stable$',
|
|
||||||
),
|
|
||||||
), $this->check($json), 'dummy');
|
|
||||||
|
|
||||||
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "dev" }';
|
$json = '{ "name": "vendor/package", "description": "generic description", "minimum-stability": "dev" }';
|
||||||
$this->assertTrue($this->check($json), 'dev');
|
$this->assertTrue($this->check($json), 'dev');
|
||||||
|
|
Loading…
Reference in New Issue