public-mirrors/composer
1
0
Fork 0
mirror of https://github.com/composer/composer synced 2025-05-09 00:22:53 +00:00
Code Activity

[Tests] Use static data providers (#11197)

Browse source
This commit is contained in:
Ion Bazan 2022-11-24 21:39:08 +08:00 • committed by GitHub
parent 0cf57255d4
commit 8ff237afb6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
86 changed files with 715 additions and 723 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tests/Composer/Test/DependencyResolver/PoolOptimizerTest.php
View file

@ -42,12 +42,12 @@ class PoolOptimizerTest extends TestCase
if (isset($requestData['locked'])) {
foreach ($requestData['locked'] as $package) {
$request->lockPackage($this->loadPackage($package));
$request->lockPackage(self::loadPackage($package));
}
}
if (isset($requestData['fixed'])) {
foreach ($requestData['fixed'] as $package) {
$request->fixPackage($this->loadPackage($package));
$request->fixPackage(self::loadPackage($package));
}
}
@ -70,9 +70,9 @@ class PoolOptimizerTest extends TestCase
);
}
public function provideIntegrationTests(): array
public static function provideIntegrationTests(): array
{
$fixturesDir = realpath(__DIR__.'/Fixtures/pooloptimizer/');
$fixturesDir = (string) realpath(__DIR__.'/Fixtures/pooloptimizer/');
$tests = [];
foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($fixturesDir), \RecursiveIteratorIterator::LEAVES_ONLY) as $file) {
$file = (string) $file;
@ -82,11 +82,11 @@ class PoolOptimizerTest extends TestCase
}
try {
$testData = $this->readTestFile($file, $fixturesDir);
$testData = self::readTestFile($file, $fixturesDir);
$message = $testData['TEST'];
$requestData = JsonFile::parseJson($testData['REQUEST']);
$packagesBefore = $this->loadPackages(JsonFile::parseJson($testData['POOL-BEFORE']));
$expectedPackages = $this->loadPackages(JsonFile::parseJson($testData['POOL-AFTER']));
$packagesBefore = self::loadPackages(JsonFile::parseJson($testData['POOL-BEFORE']));
$expectedPackages = self::loadPackages(JsonFile::parseJson($testData['POOL-AFTER']));
} catch (\Exception $e) {
die(sprintf('Test "%s" is not valid: '.$e->getMessage(), str_replace($fixturesDir.'/', '', $file)));
}
@ -100,7 +100,7 @@ class PoolOptimizerTest extends TestCase
/**
* @return mixed[]
*/
protected function readTestFile(string $file, string $fixturesDir): array
protected static function readTestFile(string $file, string $fixturesDir): array
{
$tokens = Preg::split('#(?:^|\n*)--([A-Z-]+)--\n#', file_get_contents($file), -1, PREG_SPLIT_DELIM_CAPTURE);
@ -171,12 +171,12 @@ class PoolOptimizerTest extends TestCase
* @param mixed[][] $packagesData
* @return BasePackage[]
*/
private function loadPackages(array $packagesData): array
private static function loadPackages(array $packagesData): array
{
$packages = [];
foreach ($packagesData as $packageData) {
$packages[] = $package = $this->loadPackage($packageData);
$packages[] = $package = self::loadPackage($packageData);
if ($package instanceof AliasPackage) {
$packages[] = $package->getAliasOf();
}
@ -188,7 +188,7 @@ class PoolOptimizerTest extends TestCase
/**
* @param mixed[] $packageData
*/
private function loadPackage(array $packageData): BasePackage
private static function loadPackage(array $packageData): BasePackage
{
$loader = new ArrayLoader();