public-mirrors/composer
1
0
Fork 0
mirror of https://github.com/composer/composer synced 2025-05-09 00:22:53 +00:00
Code Activity

[Tests] Use static data providers (#11197)

Browse source
This commit is contained in:
Ion Bazan 2022-11-24 21:39:08 +08:00 • committed by GitHub
parent 0cf57255d4
commit 8ff237afb6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
86 changed files with 715 additions and 723 deletions
Download patch file Download diff file Expand all files Collapse all files

44
tests/Composer/Test/Repository/ArrayRepositoryTest.php
View file

@ -21,22 +21,22 @@ class ArrayRepositoryTest extends TestCase
public function testAddPackage(): void
{
$repo = new ArrayRepository;
$repo->addPackage($this->getPackage('foo', '1'));
$repo->addPackage(self::getPackage('foo', '1'));
$this->assertCount(1, $repo);
}
public function testRemovePackage(): void
{
$package = $this->getPackage('bar', '2');
$package = self::getPackage('bar', '2');
$repo = new ArrayRepository;
$repo->addPackage($this->getPackage('foo', '1'));
$repo->addPackage(self::getPackage('foo', '1'));
$repo->addPackage($package);
$this->assertCount(2, $repo);
$repo->removePackage($this->getPackage('foo', '1'));
$repo->removePackage(self::getPackage('foo', '1'));
$this->assertCount(1, $repo);
$this->assertEquals([$package], $repo->getPackages());
@ -45,19 +45,19 @@ class ArrayRepositoryTest extends TestCase
public function testHasPackage(): void
{
$repo = new ArrayRepository;
$repo->addPackage($this->getPackage('foo', '1'));
$repo->addPackage($this->getPackage('bar', '2'));
$repo->addPackage(self::getPackage('foo', '1'));
$repo->addPackage(self::getPackage('bar', '2'));
$this->assertTrue($repo->hasPackage($this->getPackage('foo', '1')));
$this->assertFalse($repo->hasPackage($this->getPackage('bar', '1')));
$this->assertTrue($repo->hasPackage(self::getPackage('foo', '1')));
$this->assertFalse($repo->hasPackage(self::getPackage('bar', '1')));
}
public function testFindPackages(): void
{
$repo = new ArrayRepository();
$repo->addPackage($this->getPackage('foo', '1'));
$repo->addPackage($this->getPackage('bar', '2'));
$repo->addPackage($this->getPackage('bar', '3'));
$repo->addPackage(self::getPackage('foo', '1'));
$repo->addPackage(self::getPackage('bar', '2'));
$repo->addPackage(self::getPackage('bar', '3'));
$foo = $repo->findPackages('foo');
$this->assertCount(1, $foo);
@ -72,14 +72,14 @@ class ArrayRepositoryTest extends TestCase
{
$repo = new ArrayRepository();
$package = $this->getPackage('foo', '1');
$alias = $this->getAliasPackage($package, '2');
$package = self::getPackage('foo', '1');
$alias = self::getAliasPackage($package, '2');
$repo->addPackage($alias);
$this->assertCount(2, $repo);
$this->assertTrue($repo->hasPackage($this->getPackage('foo', '1')));
$this->assertTrue($repo->hasPackage($this->getPackage('foo', '2')));
$this->assertTrue($repo->hasPackage(self::getPackage('foo', '1')));
$this->assertTrue($repo->hasPackage(self::getPackage('foo', '2')));
$repo->removePackage($alias);
@ -90,8 +90,8 @@ class ArrayRepositoryTest extends TestCase
{
$repo = new ArrayRepository();
$repo->addPackage($this->getPackage('foo', '1'));
$repo->addPackage($this->getPackage('bar', '1'));
$repo->addPackage(self::getPackage('foo', '1'));
$repo->addPackage(self::getPackage('bar', '1'));
$this->assertSame(
[['name' => 'foo', 'description' => null]],
@ -112,10 +112,10 @@ class ArrayRepositoryTest extends TestCase
{
$repo = new ArrayRepository();
$repo->addPackage($this->getPackage('foo', '1', 'Composer\Package\CompletePackage'));
$repo->addPackage($this->getPackage('bar', '1', 'Composer\Package\CompletePackage'));
$repo->addPackage(self::getPackage('foo', '1', 'Composer\Package\CompletePackage'));
$repo->addPackage(self::getPackage('bar', '1', 'Composer\Package\CompletePackage'));
$package = $this->getPackage('foobar', '1', 'Composer\Package\CompletePackage');
$package = self::getPackage('foobar', '1', 'Composer\Package\CompletePackage');
$package->setType('composer-plugin');
$repo->addPackage($package);
@ -136,10 +136,10 @@ class ArrayRepositoryTest extends TestCase
{
$repo = new ArrayRepository();
$package1 = $this->getPackage('foo1', '1');
$package1 = self::getPackage('foo1', '1');
$package1->setAbandoned(true);
$repo->addPackage($package1);
$package2 = $this->getPackage('foo2', '1');
$package2 = self::getPackage('foo2', '1');
$package2->setAbandoned('bar');
$repo->addPackage($package2);

4
tests/Composer/Test/Repository/ComposerRepositoryTest.php
View file

@ -61,7 +61,7 @@ class ComposerRepositoryTest extends TestCase
}
}
public function loadDataProvider(): array
public static function loadDataProvider(): array
{
return [
// Old repository format
@ -301,7 +301,7 @@ class ComposerRepositoryTest extends TestCase
$this->assertSame($expected, $method->invoke($repository, $url));
}
public function provideCanonicalizeUrlTestCases(): array
public static function provideCanonicalizeUrlTestCases(): array
{
return [
[

46
tests/Composer/Test/Repository/CompositeRepositoryTest.php
View file

@ -21,27 +21,27 @@ class CompositeRepositoryTest extends TestCase
public function testHasPackage(): void
{
$arrayRepoOne = new ArrayRepository;
$arrayRepoOne->addPackage($this->getPackage('foo', '1'));
$arrayRepoOne->addPackage(self::getPackage('foo', '1'));
$arrayRepoTwo = new ArrayRepository;
$arrayRepoTwo->addPackage($this->getPackage('bar', '1'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '1'));
$repo = new CompositeRepository([$arrayRepoOne, $arrayRepoTwo]);
$this->assertTrue($repo->hasPackage($this->getPackage('foo', '1')), "Should have package 'foo/1'");
$this->assertTrue($repo->hasPackage($this->getPackage('bar', '1')), "Should have package 'bar/1'");
$this->assertTrue($repo->hasPackage(self::getPackage('foo', '1')), "Should have package 'foo/1'");
$this->assertTrue($repo->hasPackage(self::getPackage('bar', '1')), "Should have package 'bar/1'");
$this->assertFalse($repo->hasPackage($this->getPackage('foo', '2')), "Should not have package 'foo/2'");
$this->assertFalse($repo->hasPackage($this->getPackage('bar', '2')), "Should not have package 'bar/2'");
$this->assertFalse($repo->hasPackage(self::getPackage('foo', '2')), "Should not have package 'foo/2'");
$this->assertFalse($repo->hasPackage(self::getPackage('bar', '2')), "Should not have package 'bar/2'");
}
public function testFindPackage(): void
{
$arrayRepoOne = new ArrayRepository;
$arrayRepoOne->addPackage($this->getPackage('foo', '1'));
$arrayRepoOne->addPackage(self::getPackage('foo', '1'));
$arrayRepoTwo = new ArrayRepository;
$arrayRepoTwo->addPackage($this->getPackage('bar', '1'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '1'));
$repo = new CompositeRepository([$arrayRepoOne, $arrayRepoTwo]);
@ -55,14 +55,14 @@ class CompositeRepositoryTest extends TestCase
public function testFindPackages(): void
{
$arrayRepoOne = new ArrayRepository;
$arrayRepoOne->addPackage($this->getPackage('foo', '1'));
$arrayRepoOne->addPackage($this->getPackage('foo', '2'));
$arrayRepoOne->addPackage($this->getPackage('bat', '1'));
$arrayRepoOne->addPackage(self::getPackage('foo', '1'));
$arrayRepoOne->addPackage(self::getPackage('foo', '2'));
$arrayRepoOne->addPackage(self::getPackage('bat', '1'));
$arrayRepoTwo = new ArrayRepository;
$arrayRepoTwo->addPackage($this->getPackage('bar', '1'));
$arrayRepoTwo->addPackage($this->getPackage('bar', '2'));
$arrayRepoTwo->addPackage($this->getPackage('foo', '3'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '1'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '2'));
$arrayRepoTwo->addPackage(self::getPackage('foo', '3'));
$repo = new CompositeRepository([$arrayRepoOne, $arrayRepoTwo]);
@ -82,10 +82,10 @@ class CompositeRepositoryTest extends TestCase
public function testGetPackages(): void
{
$arrayRepoOne = new ArrayRepository;
$arrayRepoOne->addPackage($this->getPackage('foo', '1'));
$arrayRepoOne->addPackage(self::getPackage('foo', '1'));
$arrayRepoTwo = new ArrayRepository;
$arrayRepoTwo->addPackage($this->getPackage('bar', '1'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '1'));
$repo = new CompositeRepository([$arrayRepoOne, $arrayRepoTwo]);
@ -100,12 +100,12 @@ class CompositeRepositoryTest extends TestCase
public function testAddRepository(): void
{
$arrayRepoOne = new ArrayRepository;
$arrayRepoOne->addPackage($this->getPackage('foo', '1'));
$arrayRepoOne->addPackage(self::getPackage('foo', '1'));
$arrayRepoTwo = new ArrayRepository;
$arrayRepoTwo->addPackage($this->getPackage('bar', '1'));
$arrayRepoTwo->addPackage($this->getPackage('bar', '2'));
$arrayRepoTwo->addPackage($this->getPackage('bar', '3'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '1'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '2'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '3'));
$repo = new CompositeRepository([$arrayRepoOne]);
$this->assertCount(1, $repo, "Composite repository should have just one package before addRepository() is called");
@ -116,10 +116,10 @@ class CompositeRepositoryTest extends TestCase
public function testCount(): void
{
$arrayRepoOne = new ArrayRepository;
$arrayRepoOne->addPackage($this->getPackage('foo', '1'));
$arrayRepoOne->addPackage(self::getPackage('foo', '1'));
$arrayRepoTwo = new ArrayRepository;
$arrayRepoTwo->addPackage($this->getPackage('bar', '1'));
$arrayRepoTwo->addPackage(self::getPackage('bar', '1'));
$repo = new CompositeRepository([$arrayRepoOne, $arrayRepoTwo]);
@ -137,7 +137,7 @@ class CompositeRepositoryTest extends TestCase
$this->assertEquals([], call_user_func_array([$repo, $method], $args));
}
public function provideMethodCalls(): array
public static function provideMethodCalls(): array
{
return [
['findPackages', ['foo']],

28
tests/Composer/Test/Repository/FilesystemRepositoryTest.php
View file

@ -119,8 +119,8 @@ class FilesystemRepositoryTest extends TestCase
]);
$repository->setDevPackageNames(['mypkg2']);
$repository->addPackage($this->getPackage('mypkg2', '1.2.3'));
$repository->addPackage($this->getPackage('mypkg', '0.1.10'));
$repository->addPackage(self::getPackage('mypkg2', '1.2.3'));
$repository->addPackage(self::getPackage('mypkg', '0.1.10'));
$repository->write(true, $im);
}
@ -131,36 +131,36 @@ class FilesystemRepositoryTest extends TestCase
$json = new JsonFile($dir.'/installed.json');
$rootPackage = $this->getRootPackage('__root__', 'dev-master');
$rootPackage = self::getRootPackage('__root__', 'dev-master');
$rootPackage->setSourceReference('sourceref-by-default');
$rootPackage->setDistReference('distref');
$this->configureLinks($rootPackage, ['provide' => ['foo/impl' => '2.0']]);
$rootPackage = $this->getAliasPackage($rootPackage, '1.10.x-dev');
self::configureLinks($rootPackage, ['provide' => ['foo/impl' => '2.0']]);
$rootPackage = self::getAliasPackage($rootPackage, '1.10.x-dev');
$repository = new FilesystemRepository($json, true, $rootPackage);
$repository->setDevPackageNames(['c/c']);
$pkg = $this->getPackage('a/provider', '1.1');
$this->configureLinks($pkg, ['provide' => ['foo/impl' => '^1.1', 'foo/impl2' => '2.0']]);
$pkg = self::getPackage('a/provider', '1.1');
self::configureLinks($pkg, ['provide' => ['foo/impl' => '^1.1', 'foo/impl2' => '2.0']]);
$pkg->setDistReference('distref-as-no-source');
$repository->addPackage($pkg);
$pkg = $this->getPackage('a/provider2', '1.2');
$this->configureLinks($pkg, ['provide' => ['foo/impl' => 'self.version', 'foo/impl2' => '2.0']]);
$pkg = self::getPackage('a/provider2', '1.2');
self::configureLinks($pkg, ['provide' => ['foo/impl' => 'self.version', 'foo/impl2' => '2.0']]);
$pkg->setSourceReference('sourceref');
$pkg->setDistReference('distref-as-installed-from-dist');
$pkg->setInstallationSource('dist');
$repository->addPackage($pkg);
$repository->addPackage($this->getAliasPackage($pkg, '1.4'));
$repository->addPackage(self::getAliasPackage($pkg, '1.4'));
$pkg = $this->getPackage('b/replacer', '2.2');
$this->configureLinks($pkg, ['replace' => ['foo/impl2' => 'self.version', 'foo/replaced' => '^3.0']]);
$pkg = self::getPackage('b/replacer', '2.2');
self::configureLinks($pkg, ['replace' => ['foo/impl2' => 'self.version', 'foo/replaced' => '^3.0']]);
$repository->addPackage($pkg);
$pkg = $this->getPackage('c/c', '3.0');
$pkg = self::getPackage('c/c', '3.0');
$repository->addPackage($pkg);
$pkg = $this->getPackage('meta/package', '3.0');
$pkg = self::getPackage('meta/package', '3.0');
$pkg->setType('metapackage');
$repository->addPackage($pkg);

8
tests/Composer/Test/Repository/FilterRepositoryTest.php
View file

@ -28,10 +28,10 @@ class FilterRepositoryTest extends TestCase
public function setUp(): void
{
$this->arrayRepo = new ArrayRepository();
$this->arrayRepo->addPackage($this->getPackage('foo/aaa', '1.0.0'));
$this->arrayRepo->addPackage($this->getPackage('foo/bbb', '1.0.0'));
$this->arrayRepo->addPackage($this->getPackage('bar/xxx', '1.0.0'));
$this->arrayRepo->addPackage($this->getPackage('baz/yyy', '1.0.0'));
$this->arrayRepo->addPackage(self::getPackage('foo/aaa', '1.0.0'));
$this->arrayRepo->addPackage(self::getPackage('foo/bbb', '1.0.0'));
$this->arrayRepo->addPackage(self::getPackage('bar/xxx', '1.0.0'));
$this->arrayRepo->addPackage(self::getPackage('baz/yyy', '1.0.0'));
}
/**

8
tests/Composer/Test/Repository/InstalledRepositoryTest.php
View file

@ -24,12 +24,12 @@ class InstalledRepositoryTest extends TestCase
public function testFindPackagesWithReplacersAndProviders(): void
{
$arrayRepoOne = new InstalledArrayRepository;
$arrayRepoOne->addPackage($foo = $this->getPackage('foo', '1'));
$arrayRepoOne->addPackage($foo2 = $this->getPackage('foo', '2'));
$arrayRepoOne->addPackage($foo = self::getPackage('foo', '1'));
$arrayRepoOne->addPackage($foo2 = self::getPackage('foo', '2'));
$arrayRepoTwo = new InstalledArrayRepository;
$arrayRepoTwo->addPackage($bar = $this->getPackage('bar', '1'));
$arrayRepoTwo->addPackage($bar2 = $this->getPackage('bar', '2'));
$arrayRepoTwo->addPackage($bar = self::getPackage('bar', '1'));
$arrayRepoTwo->addPackage($bar2 = self::getPackage('bar', '2'));
$foo->setReplaces(['provided' => new Link('foo', 'provided', new MatchAllConstraint())]);
$bar2->setProvides(['provided' => new Link('bar', 'provided', new MatchAllConstraint())]);

2
tests/Composer/Test/Repository/PathRepositoryTest.php
View file

@ -37,7 +37,7 @@ class PathRepositoryTest extends TestCase
$repository->getPackages();
$this->assertSame(1, $repository->count());
$this->assertTrue($repository->hasPackage($this->getPackage('test/path-versioned', '0.0.2')));
$this->assertTrue($repository->hasPackage(self::getPackage('test/path-versioned', '0.0.2')));
}
public function testLoadPackageFromFileSystemWithoutVersion(): void

4
tests/Composer/Test/Repository/PlatformRepositoryTest.php
View file

@ -36,7 +36,7 @@ class PlatformRepositoryTest extends TestCase
self::assertSame('2.1.0', $hhvm->getPrettyVersion());
}
public function providePhpFlavorTestCases(): array
public static function providePhpFlavorTestCases(): array
{
return [
[
@ -1202,7 +1202,7 @@ Linked Version => 1.2.11',
foreach ($links as $link) {
self::assertSame($sourcePackage->getName(), $link->getSource());
self::assertContains($link->getTarget(), $expectedLinks, sprintf('%s: package %s not in %s', $context, $link->getTarget(), var_export($expectedLinks, true)));
self::assertTrue($link->getConstraint()->matches($this->getVersionConstraint('=', $sourcePackage->getVersion())));
self::assertTrue($link->getConstraint()->matches(self::getVersionConstraint('=', $sourcePackage->getVersion())));
}
}

2
tests/Composer/Test/Repository/RepositoryFactoryTest.php
View file

@ -63,7 +63,7 @@ class RepositoryFactoryTest extends TestCase
$this->assertSame($expected, RepositoryFactory::generateRepositoryName($index, $config, $existingRepos));
}
public function generateRepositoryNameProvider(): array
public static function generateRepositoryNameProvider(): array
{
return [
[0, [], [], '0'],

2
tests/Composer/Test/Repository/RepositoryManagerTest.php
View file

@ -89,7 +89,7 @@ class RepositoryManagerTest extends TestCase
$this->assertInstanceOf('Composer\Repository\RepositoryInterface', $rm->createRepository($type, $options));
}
public function provideRepoCreationTestCases(): array
public static function provideRepoCreationTestCases(): array
{
$cases = [
['composer', ['url' => 'http://example.org']],

50
tests/Composer/Test/Repository/RepositoryUtilsTest.php
View file

@ -36,22 +36,22 @@ class RepositoryUtilsTest extends TestCase
/**
* @return array<PackageInterface>
*/
private function getPackages(): array
private static function getPackages(): array
{
$packageA = $this->getPackage('required/a');
$packageB = $this->getPackage('required/b');
$this->configureLinks($packageB, ['require' => ['required/c' => '*']]);
$packageC = $this->getPackage('required/c');
$packageCAlias = $this->getAliasPackage($packageC, '2.0.0');
$packageA = self::getPackage('required/a');
$packageB = self::getPackage('required/b');
self::configureLinks($packageB, ['require' => ['required/c' => '*']]);
$packageC = self::getPackage('required/c');
$packageCAlias = self::getAliasPackage($packageC, '2.0.0');
$packageCircular = $this->getPackage('required/circular');
$this->configureLinks($packageCircular, ['require' => ['required/circular-b' => '*']]);
$packageCircularB = $this->getPackage('required/circular-b');
$this->configureLinks($packageCircularB, ['require' => ['required/circular' => '*']]);
$packageCircular = self::getPackage('required/circular');
self::configureLinks($packageCircular, ['require' => ['required/circular-b' => '*']]);
$packageCircularB = self::getPackage('required/circular-b');
self::configureLinks($packageCircularB, ['require' => ['required/circular' => '*']]);
return [
$this->getPackage('dummy/pkg'),
$this->getPackage('dummy/pkg2', '2.0.0'),
self::getPackage('dummy/pkg'),
self::getPackage('dummy/pkg2', '2.0.0'),
'a' => $packageA,
'b' => $packageB,
'c' => $packageC,
@ -61,31 +61,31 @@ class RepositoryUtilsTest extends TestCase
];
}
public function provideFilterRequireTests(): Generator
public static function provideFilterRequireTests(): Generator
{
$pkgs = $this->getPackages();
$pkgs = self::getPackages();
$requirer = $this->getPackage('requirer/pkg');
$requirer = self::getPackage('requirer/pkg');
yield 'no require' => [$pkgs, $requirer, []];
$requirer = $this->getPackage('requirer/pkg');
$this->configureLinks($requirer, ['require-dev' => ['required/a' => '*']]);
$requirer = self::getPackage('requirer/pkg');
self::configureLinks($requirer, ['require-dev' => ['required/a' => '*']]);
yield 'require-dev has no effect' => [$pkgs, $requirer, []];
$requirer = $this->getPackage('requirer/pkg');
$this->configureLinks($requirer, ['require' => ['required/a' => '*']]);
$requirer = self::getPackage('requirer/pkg');
self::configureLinks($requirer, ['require' => ['required/a' => '*']]);
yield 'simple require' => [$pkgs, $requirer, ['a']];
$requirer = $this->getPackage('requirer/pkg');
$this->configureLinks($requirer, ['require' => ['required/a' => 'dev-lala']]);
$requirer = self::getPackage('requirer/pkg');
self::configureLinks($requirer, ['require' => ['required/a' => 'dev-lala']]);
yield 'require constraint is irrelevant' => [$pkgs, $requirer, ['a']];
$requirer = $this->getPackage('requirer/pkg');
$this->configureLinks($requirer, ['require' => ['required/b' => '*']]);
$requirer = self::getPackage('requirer/pkg');
self::configureLinks($requirer, ['require' => ['required/b' => '*']]);
yield 'require transitive deps and aliases are included' => [$pkgs, $requirer, ['b', 'c', 'c-alias']];
$requirer = $this->getPackage('requirer/pkg');
$this->configureLinks($requirer, ['require' => ['required/circular' => '*']]);
$requirer = self::getPackage('requirer/pkg');
self::configureLinks($requirer, ['require' => ['required/circular' => '*']]);
yield 'circular deps are no problem' => [$pkgs, $requirer, ['circular', 'circular-b']];
}
}

4
tests/Composer/Test/Repository/Vcs/GitHubDriverTest.php
View file

@ -330,7 +330,7 @@ class GitHubDriverTest extends TestCase
/**
* @return list<array{string}>
*/
public function invalidUrlProvider()
public static function invalidUrlProvider()
{
return [
['https://github.com/acme'],
@ -352,7 +352,7 @@ class GitHubDriverTest extends TestCase
/**
* @return list<array{bool, string}>
*/
public function supportsProvider(): array
public static function supportsProvider(): array
{
return [
[false, 'https://github.com/acme'],

4
tests/Composer/Test/Repository/Vcs/GitLabDriverTest.php
View file

@ -75,7 +75,7 @@ class GitLabDriverTest extends TestCase
$fs->removeDirectory($this->home);
}
public function provideInitializeUrls(): array
public static function provideInitializeUrls(): array
{
return [
['https://gitlab.com/mygroup/myproject', 'https://gitlab.com/api/v4/projects/mygroup%2Fmyproject'],
@ -441,7 +441,7 @@ JSON;
$this->assertSame($expected, GitLabDriver::supports($this->io, $this->config, $url));
}
public function dataForTestSupports(): array
public static function dataForTestSupports(): array
{
return [
['http://gitlab.com/foo/bar', true],

2
tests/Composer/Test/Repository/Vcs/HgDriverTest.php
View file

@ -55,7 +55,7 @@ class HgDriverTest extends TestCase
);
}
public function supportsDataProvider(): array
public static function supportsDataProvider(): array
{
return [
['ssh://bitbucket.org/user/repo'],