public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

CS: Typehint array, remove unnecessary docblock, call spl_object_hash once

pull/9312/head
Nils Adermann 2020-10-21 18:11:24 +02:00
parent 7b4cb9c370
commit 9338401be7
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Composer/DependencyResolver/Solver.php
View File

@ -514,16 +514,12 @@ class Solver
return array($learnedLiterals[0], $ruleLevel, $newRule, $why); return array($learnedLiterals[0], $ruleLevel, $newRule, $why);
} }
/** private function analyzeUnsolvableRule(Problem $problem, Rule $conflictRule, array &$ruleSeen)
* @param Problem $problem
* @param Rule $conflictRule
*/
private function analyzeUnsolvableRule(Problem $problem, Rule $conflictRule, &$ruleSeen)
{ {
$ruleSeen[spl_object_hash($conflictRule)] = true; $why = spl_object_hash($conflictRule);
$ruleSeen[$why] = true;
if ($conflictRule->getType() == RuleSet::TYPE_LEARNED) { if ($conflictRule->getType() == RuleSet::TYPE_LEARNED) {
$why = spl_object_hash($conflictRule);
$learnedWhy = $this->learnedWhy[$why]; $learnedWhy = $this->learnedWhy[$why];
$problemRules = $this->learnedPool[$learnedWhy]; $problemRules = $this->learnedPool[$learnedWhy];