1
0
Fork 0

fix docstring and useless return

pull/6159/head
Guillaume ZITTA 2017-02-14 17:44:56 +01:00
parent abf06913a2
commit 98b7bd68b4
1 changed files with 2 additions and 3 deletions

View File

@ -70,7 +70,7 @@ class ZipDownloader extends ArchiveDownloader
* @param string $file File to extract * @param string $file File to extract
* @param string $path Path where to extract file * @param string $path Path where to extract file
* @param bool $isFallback If true it is called as a fallback and should not throw exception * @param bool $isFallback If true it is called as a fallback and should not throw exception
* @return bool True if succeed * @return bool|\Exception True if succeed, an Exception if not
*/ */
protected function extractWithSystemUnzip($file, $path, $isFallback) protected function extractWithSystemUnzip($file, $path, $isFallback)
{ {
@ -92,7 +92,6 @@ class ZipDownloader extends ArchiveDownloader
if ( $isFallback ) { if ( $isFallback ) {
$this->io->write($processError); $this->io->write($processError);
return;
} }
return new \RuntimeException($processError); return new \RuntimeException($processError);
} }
@ -102,7 +101,7 @@ class ZipDownloader extends ArchiveDownloader
* *
* @param string $file File to extract * @param string $file File to extract
* @param string $path Path where to extract file * @param string $path Path where to extract file
* @return bool True if succeed * @return bool|\Exception True if succeed, an Exception if not
*/ */
protected function extractWithZipArchive($file, $path) protected function extractWithZipArchive($file, $path)
{ {