From 98bc4e4483364d39f5b75ffcfad30cd20a067d2a Mon Sep 17 00:00:00 2001 From: Roshan Gautam Date: Mon, 13 Apr 2015 21:22:41 +0000 Subject: [PATCH] Gitlab:Use proper fallbacks if archive download is failing --- src/Composer/Repository/Vcs/GitLabDriver.php | 89 +++++++++++++++++++- 1 file changed, 86 insertions(+), 3 deletions(-) diff --git a/src/Composer/Repository/Vcs/GitLabDriver.php b/src/Composer/Repository/Vcs/GitLabDriver.php index ae66ab53d..29ff16138 100644 --- a/src/Composer/Repository/Vcs/GitLabDriver.php +++ b/src/Composer/Repository/Vcs/GitLabDriver.php @@ -18,7 +18,7 @@ use Composer\IO\IOInterface; use Composer\Json\JsonFile; use Composer\Downloader\TransportException; use Composer\Util\RemoteFilesystem; - +use Composer\Util\GitLab; /** * Driver for GitLab API, use the Git driver for local checkouts. * @@ -54,6 +54,13 @@ class GitLabDriver extends VcsDriver */ private $branches; + /** + * Git Driver + * + * @var GitDriver + */ + protected $gitDriver; + /** * Extracts information from the repository url. * SSH urls are not supported in order to know the HTTP sheme to use. @@ -248,10 +255,86 @@ class GitLabDriver extends VcsDriver { // we need to fetch the default branch from the api $resource = $this->getApiUrl(); - - $this->project = JsonFile::parseJson($this->getContents($resource), $resource); + $this->project = JsonFile::parseJson($this->getContents($resource, true), $resource); } + protected function attemptCloneFallback() + { + + try { + // If this repository may be private and we + // cannot ask for authentication credentials (because we + // are not interactive) then we fallback to GitDriver. + $this->setupGitDriver($this->generateSshUrl()); + + return; + } catch (\RuntimeException $e) { + $this->gitDriver = null; + + $this->io->writeError('Failed to clone the '.$this->generateSshUrl().' repository, try running in interactive mode so that you can enter your credentials'); + throw $e; + } + } + + protected function setupGitDriver($url) + { + $this->gitDriver = new GitDriver( + array('url' => $url), + $this->io, + $this->config, + $this->process, + $this->remoteFilesystem + ); + $this->gitDriver->initialize(); + } + + /** + * {@inheritDoc} + */ + protected function getContents($url, $fetchingRepoData = false) + { + try { + return parent::getContents($url); + } catch (TransportException $e) { + $gitLabUtil = new GitLab($this->io, $this->config, $this->process, $this->remoteFilesystem); + + switch ($e->getCode()) { + case 401: + case 404: + // try to authorize only if we are fetching the main /repos/foo/bar data, otherwise it must be a real 404 + if (!$fetchingRepoData) { + throw $e; + } + + if ($gitLabUtil->authorizeOAuth($this->originUrl)) { + return parent::getContents($url); + } + + if (!$this->io->isInteractive()) { + return $this->attemptCloneFallback(); + } + $this->io->writeError('Failed to download ' . $this->owner . '/' . $this->repository . ':' . $e->getMessage() . ''); + $gitLabUtil->authorizeOAuthInteractively($this->originUrl, 'Your credentials are required to fetch private repository metadata ('.$this->url.')'); + + return parent::getContents($url); + + case 403: + if (!$this->io->hasAuthentication($this->originUrl) && $gitLabUtil->authorizeOAuth($this->originUrl)) { + return parent::getContents($url); + } + + if (!$this->io->isInteractive() && $fetchingRepoData) { + return $this->attemptCloneFallback(); + } + + throw $e; + + default: + throw $e; + } + } + } + /** * Uses the config `gitlab-domains` to see if the driver supports the url for the * repository given.