public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

Clobber any existing sudo leases before execution to prevent malicious code gaining root privileges.

pull/5122/head
Niels Keurentjes 2016-03-28 13:10:43 +02:00
parent 557a55fbe5
commit a0070e724b
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Composer/Console/Application.php
View File

@ -133,7 +133,8 @@ class Application extends BaseApplication
$input->setInteractive(false);
}
if (!Platform::isWindows() && function_exists('posix_getuid') && posix_getuid() === 0) {
if (!Platform::isWindows()) {
if (function_exists('posix_getuid') && posix_getuid() === 0) {
$io->writeError('<warning>Running composer as root is highly discouraged as packages, plugins and scripts cannot always be trusted</warning>');
if ($uid = getenv('SUDO_UID')) {
// Silently clobber any sudo credentials on the invoking user to avoid privilege escalations later on
@ -141,6 +142,9 @@ class Application extends BaseApplication
exec("sudo -u \\#{$uid} sudo -K > /dev/null 2>&1");
}
}
// Silently clobber any remaining sudo leases on the current user as well to avoid privilege escalations
exec("sudo -K > /dev/null 2>&1");
}
// switch working dir
if ($newWorkDir = $this->getNewWorkingDir($input)) {