From a4a9d0f0e499dad134b48e9e1ee0ae736f28cf2d Mon Sep 17 00:00:00 2001
From: Zbigniew <zczapran@gmail.com>
Date: Thu, 30 Jan 2014 23:34:28 +0000
Subject: [PATCH] [Archiver] Rules in GitExcludeFilter are too broad

---
 .../Package/Archiver/BaseExcludeFilter.php    |  2 +-
 .../Package/Archiver/GitExcludeFilterTest.php | 36 +++++++++++++++++++
 2 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 tests/Composer/Test/Package/Archiver/GitExcludeFilterTest.php

diff --git a/src/Composer/Package/Archiver/BaseExcludeFilter.php b/src/Composer/Package/Archiver/BaseExcludeFilter.php
index bba2003a8..3c89919d2 100644
--- a/src/Composer/Package/Archiver/BaseExcludeFilter.php
+++ b/src/Composer/Package/Archiver/BaseExcludeFilter.php
@@ -140,7 +140,7 @@ abstract class BaseExcludeFilter
             $pattern .= '/';
         }
 
-        $pattern .= substr(Finder\Glob::toRegex($rule), 2, -2);
+        $pattern .= substr(Finder\Glob::toRegex($rule), 2, -1);
 
         return array($pattern . '#', $negate, false);
     }
diff --git a/tests/Composer/Test/Package/Archiver/GitExcludeFilterTest.php b/tests/Composer/Test/Package/Archiver/GitExcludeFilterTest.php
new file mode 100644
index 000000000..a6d473a1e
--- /dev/null
+++ b/tests/Composer/Test/Package/Archiver/GitExcludeFilterTest.php
@@ -0,0 +1,36 @@
+<?php
+
+/*
+ * This file is part of Composer.
+ *
+ * (c) Nils Adermann <naderman@naderman.de>
+ *     Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Composer\Test\Package\Archiver;
+
+use Composer\Package\Archiver\GitExcludeFilter;
+
+class GitExcludeFilterTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @dataProvider patterns
+     */
+    public function testPatternEscape($ignore, $expected)
+    {
+        $filter = new GitExcludeFilter('/');
+
+        $this->assertEquals($expected, $filter->parseGitIgnoreLine($ignore));
+    }
+
+    public function patterns()
+    {
+        return array(
+            array('app/config/parameters.yml', array('#(?=[^\.])app/(?=[^\.])config/(?=[^\.])parameters\.yml$#', false, false)),
+            array('!app/config/parameters.yml', array('#(?=[^\.])app/(?=[^\.])config/(?=[^\.])parameters\.yml$#', true, false)),
+        );
+    }
+}