1
0
Fork 0

use `.tmp` extension for temporary files

also updated `catch` block to use temporary filename
pull/9580/head
Ilya Urvachev 2021-01-06 02:17:34 +03:00
parent e829ff80bc
commit ab6e0fa961
No known key found for this signature in database
GPG Key ID: 07B9F50EF721A85D
1 changed files with 4 additions and 4 deletions

View File

@ -114,21 +114,21 @@ class Cache
$this->io->writeError('Writing '.$this->root . $file.' into cache', true, IOInterface::DEBUG);
$tempFileName = $this->root . $file . uniqid('.', true) . '.tmp';
try {
$tempFileName = $this->root . $file . uniqid('.tmp.', true);
return file_put_contents($tempFileName, $contents) !== false && rename($tempFileName, $this->root . $file);
} catch (\ErrorException $e) {
$this->io->writeError('<warning>Failed to write into cache: '.$e->getMessage().'</warning>', true, IOInterface::DEBUG);
if (preg_match('{^file_put_contents\(\): Only ([0-9]+) of ([0-9]+) bytes written}', $e->getMessage(), $m)) {
// Remove partial file.
unlink($this->root . $file);
unlink($tempFileName);
$message = sprintf(
'<warning>Writing %1$s into cache failed after %2$u of %3$u bytes written, only %4$u bytes of free space available</warning>',
$this->root . $file,
$tempFileName,
$m[1],
$m[2],
@disk_free_space($this->root . dirname($file))
@disk_free_space($this->root . dirname($tempFileName))
);
$this->io->writeError($message);