1
0
Fork 0

Fix feedback

pull/9519/head
Jordi Boggiano 2020-11-26 13:07:33 +01:00
parent e857a8216c
commit be3a520331
No known key found for this signature in database
GPG Key ID: 7BBD42C429EC80BC
1 changed files with 2 additions and 5 deletions

View File

@ -796,9 +796,6 @@ class Installer
} }
/** /**
* @param RootPackageInterface $rootPackage
* @param PlatformRepository $platformRepo
* @param RepositoryInterface|null $lockedRepository
* @return Request * @return Request
*/ */
private function createRequest(RootPackageInterface $rootPackage, PlatformRepository $platformRepo, LockArrayRepository $lockedRepository = null) private function createRequest(RootPackageInterface $rootPackage, PlatformRepository $platformRepo, LockArrayRepository $lockedRepository = null)
@ -838,13 +835,13 @@ class Installer
if ($this->updateMirrors) { if ($this->updateMirrors) {
$excludedPackages = array(); $excludedPackages = array();
if (!$includeDevRequires) { if (!$includeDevRequires) {
$excludedPackages = $this->locker->getDevPackageNames(); $excludedPackages = array_flip($this->locker->getDevPackageNames());
} }
foreach ($lockedRepository->getPackages() as $lockedPackage) { foreach ($lockedRepository->getPackages() as $lockedPackage) {
// exclude alias packages here as for root aliases, both alias and aliased are // exclude alias packages here as for root aliases, both alias and aliased are
// present in the lock repo and we only want to require the aliased version // present in the lock repo and we only want to require the aliased version
if (!$lockedPackage instanceof AliasPackage && !in_array($lockedPackage->getName(), $excludedPackages, true)) { if (!$lockedPackage instanceof AliasPackage && !isset($excludedPackages[$lockedPackage->getName()])) {
$request->requireName($lockedPackage->getName(), new Constraint('==', $lockedPackage->getVersion())); $request->requireName($lockedPackage->getName(), new Constraint('==', $lockedPackage->getVersion()));
} }
} }