From c2a2198089b402d5d2ac55ad413992770028a173 Mon Sep 17 00:00:00 2001 From: megubyte <939805+megubyte@users.noreply.github.com> Date: Wed, 27 Oct 2021 13:41:30 +0100 Subject: [PATCH] phpstan: update tests/Composer/Test/Installer/* to level 6 standard (#10225) --- .../Installer/InstallationManagerTest.php | 17 +++++++++ .../Test/Installer/LibraryInstallerTest.php | 38 +++++++++++++++++++ .../Installer/MetapackageInstallerTest.php | 3 ++ .../SuggestedPackagesReporterTest.php | 13 +++++++ 4 files changed, 71 insertions(+) diff --git a/tests/Composer/Test/Installer/InstallationManagerTest.php b/tests/Composer/Test/Installer/InstallationManagerTest.php index c7256fe8b..687094a74 100644 --- a/tests/Composer/Test/Installer/InstallationManagerTest.php +++ b/tests/Composer/Test/Installer/InstallationManagerTest.php @@ -21,8 +21,19 @@ use Composer\Test\TestCase; class InstallationManagerTest extends TestCase { + /** + * @var \Composer\Repository\InstalledRepositoryInterface&\PHPUnit\Framework\MockObject\MockObject + */ protected $repository; + + /** + * @var \Composer\Util\Loop&\PHPUnit\Framework\MockObject\MockObject + */ protected $loop; + + /** + * @var \Composer\IO\IOInterface&\PHPUnit\Framework\MockObject\MockObject + */ protected $io; public function setUp() @@ -282,12 +293,18 @@ class InstallationManagerTest extends TestCase $manager->ensureBinariesPresence($package); } + /** + * @return \Composer\Installer\InstallerInterface&\PHPUnit\Framework\MockObject\MockObject + */ private function createInstallerMock() { return $this->getMockBuilder('Composer\Installer\InstallerInterface') ->getMock(); } + /** + * @return \Composer\Package\PackageInterface&\PHPUnit\Framework\MockObject\MockObject + */ private function createPackageMock() { $mock = $this->getMockBuilder('Composer\Package\PackageInterface') diff --git a/tests/Composer/Test/Installer/LibraryInstallerTest.php b/tests/Composer/Test/Installer/LibraryInstallerTest.php index 967b40db0..ee66ce65b 100644 --- a/tests/Composer/Test/Installer/LibraryInstallerTest.php +++ b/tests/Composer/Test/Installer/LibraryInstallerTest.php @@ -20,14 +20,49 @@ use Composer\Config; class LibraryInstallerTest extends TestCase { + /** + * @var \Composer\Composer + */ protected $composer; + + /** + * @var \Composer\Config + */ protected $config; + + /** + * @var string + */ protected $rootDir; + + /** + * @var string + */ protected $vendorDir; + + /** + * @var string + */ protected $binDir; + + /** + * @var \Composer\Downloader\DownloadManager&\PHPUnit\Framework\MockObject\MockObject + */ protected $dm; + + /** + * @var \Composer\Repository\InstalledRepositoryInterface&\PHPUnit\Framework\MockObject\MockObject + */ protected $repository; + + /** + * @var \Composer\IO\IOInterface&\PHPUnit\Framework\MockObject\MockObject + */ protected $io; + + /** + * @var \Composer\Util\Filesystem + */ protected $fs; protected function setUp() @@ -285,6 +320,9 @@ class LibraryInstallerTest extends TestCase $library->ensureBinariesPresence($package); } + /** + * @return \Composer\Package\PackageInterface&\PHPUnit\Framework\MockObject\MockObject + */ protected function createPackageMock() { return $this->getMockBuilder('Composer\Package\Package') diff --git a/tests/Composer/Test/Installer/MetapackageInstallerTest.php b/tests/Composer/Test/Installer/MetapackageInstallerTest.php index 012a28a5a..9eedcbe70 100644 --- a/tests/Composer/Test/Installer/MetapackageInstallerTest.php +++ b/tests/Composer/Test/Installer/MetapackageInstallerTest.php @@ -107,6 +107,9 @@ class MetapackageInstallerTest extends TestCase $this->installer->uninstall($this->repository, $package); } + /** + * @return \Composer\Package\PackageInterface&\PHPUnit\Framework\MockObject\MockObject + */ private function createPackageMock() { return $this->getMockBuilder('Composer\Package\Package') diff --git a/tests/Composer/Test/Installer/SuggestedPackagesReporterTest.php b/tests/Composer/Test/Installer/SuggestedPackagesReporterTest.php index fad4d1235..c6f5b8721 100644 --- a/tests/Composer/Test/Installer/SuggestedPackagesReporterTest.php +++ b/tests/Composer/Test/Installer/SuggestedPackagesReporterTest.php @@ -20,7 +20,14 @@ use Composer\Test\TestCase; */ class SuggestedPackagesReporterTest extends TestCase { + /** + * @var \PHPUnit\Framework\MockObject\MockObject + */ private $io; + + /** + * @var \Composer\Installer\SuggestedPackagesReporter + */ private $suggestedPackagesReporter; protected function setUp() @@ -267,6 +274,9 @@ class SuggestedPackagesReporterTest extends TestCase $this->suggestedPackagesReporter->output(SuggestedPackagesReporter::MODE_BY_PACKAGE, $repository); } + /** + * @return array + */ private function getSuggestedPackageArray() { return array( @@ -276,6 +286,9 @@ class SuggestedPackagesReporterTest extends TestCase ); } + /** + * @return \Composer\Package\PackageInterface&\PHPUnit\Framework\MockObject\MockObject + */ private function createPackageMock() { return $this->getMockBuilder('Composer\Package\Package')