public-mirrors/composer
1
0
Fork 0
mirror of https://github.com/composer/composer synced 2025-05-08 16:17:37 +00:00
Code Activity

Add ValidatingArrayLoader and more validation for the validate command

Browse source
This commit is contained in:
Jordi Boggiano 2012-07-18 17:20:01 +02:00
parent c065b5251d
commit c65af3e3a1
8 changed files with 567 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

222
tests/Composer/Test/Package/Loader/ValidatingArrayLoaderTest.php Normal file
View file

@ -0,0 +1,222 @@
<?php
/*
* This file is part of Composer.
*
* (c) Nils Adermann <naderman@naderman.de>
* Jordi Boggiano <j.boggiano@seld.be>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Composer\Test\Package\Loader;
use Composer\Package;
use Composer\Package\Loader\ValidatingArrayLoader;
class ValidatingArrayLoaderTest extends \PHPUnit_Framework_TestCase
{
/**
* @dataProvider successProvider
*/
public function testLoadSuccess($config)
{
$internalLoader = $this->getMock('Composer\Package\Loader\LoaderInterface');
$internalLoader
->expects($this->once())
->method('load')
->with($config);
$loader = new ValidatingArrayLoader($internalLoader, false);
$loader->load($config);
}
public function successProvider()
{
return array(
array( // minimal
array(
'name' => 'foo/bar',
),
),
array( // complete
array(
'name' => 'foo/bar',
'description' => 'Foo bar',
'version' => '1.0.0',
'type' => 'library',
'keywords' => array('a', 'b'),
'homepage' => 'https://foo.com',
'time' => '2010-10-10T10:10:10+00:00',
'license' => 'MIT',
'authors' => array(
array(
'name' => 'Alice',
'email' => 'alice@example.org',
'role' => 'Lead',
'homepage' => 'http://example.org',
),
array(
'name' => 'Bob',
'homepage' => 'http://example.com',
),
),
'support' => array(
'email' => 'mail@example.org',
'issues' => 'http://example.org/',
'forum' => 'http://example.org/',
'wiki' => 'http://example.org/',
'source' => 'http://example.org/',
'irc' => 'irc://example.org/example',
),
'require' => array(
'a/b' => '1.*',
'example' => '>2.0-dev,<2.4-dev',
),
'require-dev' => array(
'a/b' => '1.*',
'example' => '>2.0-dev,<2.4-dev',
),
'conflict' => array(
'a/b' => '1.*',
'example' => '>2.0-dev,<2.4-dev',
),
'replace' => array(
'a/b' => '1.*',
'example' => '>2.0-dev,<2.4-dev',
),
'provide' => array(
'a/b' => '1.*',
'example' => '>2.0-dev,<2.4-dev',
),
'suggest' => array(
'foo/bar' => 'Foo bar is very useful',
),
'autoload' => array(
'psr-0' => array(
'Foo\\Bar' => 'src/',
'' => 'fallback/libs/',
),
'classmap' => array(
'dir/',
'dir2/file.php',
),
'files' => array(
'functions.php',
),
),
'include-path' => array(
'lib/',
),
'target-dir' => 'Foo/Bar',
'minimum-stability' => 'dev',
'repositories' => array(
array(
'type' => 'composer',
'url' => 'http://packagist.org/',
)
),
'config' => array(
'bin-dir' => 'bin',
'vendor-dir' => 'vendor',
'process-timeout' => 10000,
),
'scripts' => array(
'post-update-cmd' => 'Foo\\Bar\\Baz::doSomething',
'post-install-cmd' => array(
'Foo\\Bar\\Baz::doSomething',
),
),
'extra' => array(
'random' => array('stuff' => array('deeply' => 'nested')),
),
'bin' => array(
'bin/foo',
'bin/bar',
),
),
),
array( // test as array
array(
'name' => 'foo/bar',
'license' => array('MIT', 'WTFPL'),
),
),
);
}
/**
* @dataProvider failureProvider
*/
public function testLoadFailureThrowsException($config, $expectedErrors)
{
$internalLoader = $this->getMock('Composer\Package\Loader\LoaderInterface');
$loader = new ValidatingArrayLoader($internalLoader, false);
try {
$loader->load($config);
$this->fail('Expected exception to be thrown');
} catch (\Exception $e) {
$errors = explode("\n", $e->getMessage());
sort($expectedErrors);
sort($errors);
$this->assertEquals($expectedErrors, $errors);
}
}
/**
* @dataProvider failureProvider
*/
public function testLoadSkipsInvalidDataWhenIgnoringErrors($config)
{
$internalLoader = $this->getMock('Composer\Package\Loader\LoaderInterface');
$internalLoader
->expects($this->once())
->method('load')
->with(array('name' => 'a/b'));
$loader = new ValidatingArrayLoader($internalLoader, true);
$config['name'] = 'a/b';
$loader->load($config);
}
public function failureProvider()
{
return array(
array(
array(
'name' => 'foo',
),
array(
'name : invalid value, must match [A-Za-z0-9][A-Za-z0-9_.-]*/[A-Za-z0-9][A-Za-z0-9_.-]*'
)
),
array(
array(
'name' => 'foo/bar',
'homepage' => 'foo:bar',
),
array(
'homepage : invalid value, must be a valid http/https URL'
)
),
array(
array(
'name' => 'foo/bar',
'support' => array(
'source' => 'foo:bar',
'forum' => 'foo:bar',
'issues' => 'foo:bar',
'wiki' => 'foo:bar',
),
),
array(
'support.source : invalid value, must be a valid http/https URL',
'support.forum : invalid value, must be a valid http/https URL',
'support.issues : invalid value, must be a valid http/https URL',
'support.wiki : invalid value, must be a valid http/https URL',
)
),
);
}
}