From cf1af585148e4f2c2a7321d59da7cb988b1ba117 Mon Sep 17 00:00:00 2001
From: Nils Adermann <naderman@naderman.de>
Date: Tue, 14 Jul 2015 14:18:50 +0200
Subject: [PATCH] Use bitwise operators directly in rules instead of get/set
 Bitfield

---
 src/Composer/DependencyResolver/Rule.php | 24 +++++++-----------------
 1 file changed, 7 insertions(+), 17 deletions(-)

diff --git a/src/Composer/DependencyResolver/Rule.php b/src/Composer/DependencyResolver/Rule.php
index f129c6f66..5d95d678a 100644
--- a/src/Composer/DependencyResolver/Rule.php
+++ b/src/Composer/DependencyResolver/Rule.php
@@ -72,7 +72,7 @@ class Rule
 
     public function getReason()
     {
-        return $this->getBitfield(self::BITFIELD_REASON);
+        return ($this->bitfield & (255 << self::BITFIELD_REASON)) >> self::BITFIELD_REASON;
     }
 
     public function getReasonData()
@@ -116,32 +116,32 @@ class Rule
 
     public function setType($type)
     {
-        $this->setBitfield(self::BITFIELD_TYPE, $type);
+        $this->bitfield = ($this->bitfield & ~(255 << self::BITFIELD_TYPE)) | ((255 & $type) << self::BITFIELD_TYPE);
     }
 
     public function getType()
     {
-        return $this->getBitfield(self::BITFIELD_TYPE);
+        return ($this->bitfield & (255 << self::BITFIELD_TYPE)) >> self::BITFIELD_TYPE;
     }
 
     public function disable()
     {
-        $this->setBitfield(self::BITFIELD_DISABLED, 1);
+        $this->bitfield = ($this->bitfield & ~(255 << self::BITFIELD_DISABLED)) | (1 << self::BITFIELD_DISABLED);
     }
 
     public function enable()
     {
-        $this->setBitfield(self::BITFIELD_DISABLED, 0);
+        $this->bitfield = $this->bitfield & ~(255 << self::BITFIELD_DISABLED);
     }
 
     public function isDisabled()
     {
-        return (bool) $this->getBitfield(self::BITFIELD_DISABLED);
+        return (bool) (($this->bitfield & (255 << self::BITFIELD_DISABLED)) >> self::BITFIELD_DISABLED);
     }
 
     public function isEnabled()
     {
-        return !$this->getBitfield(self::BITFIELD_DISABLED);
+        return !(($this->bitfield & (255 << self::BITFIELD_DISABLED)) >> self::BITFIELD_DISABLED);
     }
 
     /**
@@ -259,16 +259,6 @@ class Rule
         return implode(', ', $prepared);
     }
 
-    private function getBitfield($offset)
-    {
-        return ($this->bitfield & (255 << $offset)) >> $offset;
-    }
-
-    private function setBitfield($offset, $value)
-    {
-        $this->bitfield = ($this->bitfield & ~(255 << $offset)) | ((255 & $value) << $offset);
-    }
-
     /**
      * Formats a rule as a string of the format (Literal1|Literal2|...)
      *