From d271004b308c9c584e1dd4eb7b49647e4ba220e4 Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Tue, 10 Mar 2020 17:00:28 +0100 Subject: [PATCH] Also check for package requiring itself in require, not only require-dev --- src/Composer/Package/Loader/RootPackageLoader.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Composer/Package/Loader/RootPackageLoader.php b/src/Composer/Package/Loader/RootPackageLoader.php index 84e99a857..2115d7378 100644 --- a/src/Composer/Package/Loader/RootPackageLoader.php +++ b/src/Composer/Package/Loader/RootPackageLoader.php @@ -139,6 +139,11 @@ class RootPackageLoader extends ArrayLoader $aliases = $this->extractAliases($links, $aliases); $stabilityFlags = $this->extractStabilityFlags($links, $stabilityFlags, $realPackage->getMinimumStability()); $references = $this->extractReferences($links, $references); + + if (isset($links[$config['name']])) { + throw new \RuntimeException(sprintf('Root package \'%s\' cannot require itself in its composer.json' . PHP_EOL . + 'Did you accidentally name your root package after an external package?', $config['name'])); + } } } @@ -154,11 +159,6 @@ class RootPackageLoader extends ArrayLoader } } - if (isset($links[$config['name']])) { - throw new \InvalidArgumentException(sprintf('Root package \'%s\' cannot require itself in its composer.json' . PHP_EOL . - 'Did you accidentally name your root package after an external package?', $config['name'])); - } - $realPackage->setAliases($aliases); $realPackage->setStabilityFlags($stabilityFlags); $realPackage->setReferences($references);