public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

Do not apply non-array package links in ArrayLoader (#11008)

pull/11014/head
Zan Baldwin 2022-08-20 08:58:17 +02:00 committed by GitHub
parent 51774693c7
commit d2d8474013
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 38 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Composer/Package/Loader/ArrayLoader.php
View File

@ -55,17 +55,18 @@ class ArrayLoader implements LoaderInterface
$package = $this->createObject($config, $class); $package = $this->createObject($config, $class);
foreach (BasePackage::$supportedLinkTypes as $type => $opts) { foreach (BasePackage::$supportedLinkTypes as $type => $opts) {
if (isset($config[$type])) { if (!isset($config[$type]) || !is_array($config[$type])) {
$method = 'set'.ucfirst($opts['method']); continue;
$package->{$method}(
$this->parseLinks(
$package->getName(),
$package->getPrettyVersion(),
$opts['method'],
$config[$type]
)
);
} }
$method = 'set'.ucfirst($opts['method']);
$package->{$method}(
$this->parseLinks(
$package->getName(),
$package->getPrettyVersion(),
$opts['method'],
$config[$type]
)
);
} }
$package = $this->configureObject($package, $config); $package = $this->configureObject($package, $config);

27
tests/Composer/Test/Package/Loader/ArrayLoaderTest.php
View File

@ -402,4 +402,31 @@ class ArrayLoaderTest extends TestCase
$package = $this->loader->load($config); $package = $this->loader->load($config);
$this->assertCount(0, $package->getRequires()); $this->assertCount(0, $package->getRequires());
} }
public function testPackageLinksReplace(): void
{
$config = array(
'name' => 'acme/package',
'version' => 'dev-1',
'replace' => [
'coyote/package' => 'self.version',
],
);
$package = $this->loader->load($config);
$this->assertArrayHasKey('coyote/package', $package->getReplaces());
$this->assertSame('dev-1', $package->getReplaces()['coyote/package']->getConstraint()->getPrettyString());
}
public function testPackageLinksReplaceInvalid(): void
{
$config = array(
'name' => 'acme/package',
'version' => 'dev-1',
'replace' => 'coyote/package',
);
$package = $this->loader->load($config);
$this->assertCount(0, $package->getReplaces());
}
} }