1
0
Fork 0

NEW: Rewrite self.version in create-project (Fixes #1351)

When composer create-project is called and the resulting project is disconnected from the
parent repo, self.version references no longer work.  To fix that, this patch rewrites
self.version to the actual version number as part of 'composer create-project' execution
pull/1883/head
Sam Minnee 2013-05-09 13:21:04 +12:00
parent 82fc3b3eb3
commit d3437d6e76
1 changed files with 38 additions and 0 deletions

View File

@ -35,6 +35,7 @@ use Composer\Json\JsonFile;
use Composer\Util\Filesystem; use Composer\Util\Filesystem;
use Composer\Util\RemoteFilesystem; use Composer\Util\RemoteFilesystem;
use Composer\Package\Version\VersionParser; use Composer\Package\Version\VersionParser;
use Composer\Json\JsonManipulator;
/** /**
* Install a package as new project into new directory. * Install a package as new project into new directory.
@ -235,6 +236,7 @@ EOT
return 1; return 1;
} }
$vcsWasRemoved = false;
if (!$keepVcs && $installedFromVcs if (!$keepVcs && $installedFromVcs
&& ( && (
!$io->isInteractive() !$io->isInteractive()
@ -259,11 +261,47 @@ EOT
} catch (\Exception $e) { } catch (\Exception $e) {
$io->write('<error>An error occurred while removing the VCS metadata: '.$e->getMessage().'</error>'); $io->write('<error>An error occurred while removing the VCS metadata: '.$e->getMessage().'</error>');
} }
$vcsWasRemoved = true;
}
// Rewriting self.version dependencies with explicit version numbers
if($vcsWasRemoved || !$installedFromVcs) {
$package = $composer->getPackage();
$requires = $package->getRequires();
$requirementsToUpdate = array();
foreach($requires as $require) {
if($require->getPrettyConstraint() == 'self.version') {
$requirementsToUpdate[] = $require->getTarget();
}
}
if($requirementsToUpdate) {
$io->write("<info>Rewriting self.version entries for " . implode(", ",$requirementsToUpdate) . " to " . $package->getVersion() . "</info>");
$this->rewriteSelfVersion(Factory::getComposerFile(), $requirementsToUpdate, $package->getVersion());
}
} }
return 0; return 0;
} }
private function rewriteSelfVersion($filename, array $packages, $newVersion)
{
$contents = file_get_contents($filename);
$manipulator = new JsonManipulator($contents);
foreach ($packages as $package) {
if (!$manipulator->addLink('require', $package, $newVersion)) {
return false;
}
}
file_put_contents($filename, $manipulator->getContents());
return true;
}
protected function createDownloadManager(IOInterface $io, Config $config) protected function createDownloadManager(IOInterface $io, Config $config)
{ {
$factory = new Factory(); $factory = new Factory();