public-mirrors
/
composer
mirror of https://github.com/composer/composer
1
0
Fork 0
Code

Update doc block, remove redundant clearstatcache

pull/7941/head
johnstevenson 2019-02-10 14:41:20 +00:00
parent e085a72f64
commit da0dc74414
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Composer/Util/Filesystem.php
View File

@ -652,6 +652,11 @@ class Filesystem
* that the mode value returned from lstat (which gives the status of the * that the mode value returned from lstat (which gives the status of the
* link itself) is not a directory. * link itself) is not a directory.
* *
* This relies on the fact that PHP does not set this value because there is
* no universal file type flag for a junction or a mount point. However a
* bug in PHP can cause a random value to be returned and this could result
* in a junction not being detected: https://bugs.php.net/bug.php?id=77552
*
* @param string $junction Path to check. * @param string $junction Path to check.
* @return bool * @return bool
*/ */
@ -664,9 +669,8 @@ class Filesystem
return false; return false;
} }
// Important to clear cache first // Important to clear all caches first
clearstatcache(true, $junction); clearstatcache(true, $junction);
clearstatcache(false);
$stat = lstat($junction); $stat = lstat($junction);
// S_IFDIR is 0x4000, S_IFMT is the 0xF000 bitmask // S_IFDIR is 0x4000, S_IFMT is the 0xF000 bitmask