1
0
Fork 0

Clean ups after feedback

pull/1015/head
Jordi Boggiano 2012-08-24 00:14:54 +02:00
parent a0903d4d35
commit e1bd2fd6df
4 changed files with 7 additions and 4 deletions

View File

@ -123,7 +123,6 @@ EOT
return false; return false;
} }
if ($package->getName() === $name) {var_dump((string) $package);}
}); });
} }

View File

@ -63,8 +63,6 @@ EOT
$repos = new CompositeRepository(array_merge(array($installedRepo), $defaultRepos)); $repos = new CompositeRepository(array_merge(array($installedRepo), $defaultRepos));
} }
$time = microtime(true);
$this->tokens = $input->getArgument('tokens'); $this->tokens = $input->getArgument('tokens');
$this->output = $output; $this->output = $output;
$repos->filterPackages(array($this, 'processPackage'), 'Composer\Package\CompletePackage'); $repos->filterPackages(array($this, 'processPackage'), 'Composer\Package\CompletePackage');

View File

@ -52,7 +52,7 @@ interface RepositoryInterface extends \Countable
public function findPackages($name, $version = null); public function findPackages($name, $version = null);
/** /**
* Filters all the packages throuhg a callback * Filters all the packages through a callback
* *
* The packages are not guaranteed to be instances in the repository * The packages are not guaranteed to be instances in the repository
* and this can only be used for streaming through a list of packages. * and this can only be used for streaming through a list of packages.

View File

@ -23,6 +23,8 @@ interface StreamableRepositoryInterface extends RepositoryInterface
/** /**
* Return partial package data without loading them all to save on memory * Return partial package data without loading them all to save on memory
* *
* The function must return an array of package arrays.
*
* The package array must contain the following fields: * The package array must contain the following fields:
* - name: package name (normalized/lowercased) * - name: package name (normalized/lowercased)
* - repo: reference to the repository instance * - repo: reference to the repository instance
@ -32,6 +34,10 @@ interface StreamableRepositoryInterface extends RepositoryInterface
* - alias: pretty alias that this package should be aliased to, optional * - alias: pretty alias that this package should be aliased to, optional
* - alias_normalized: normalized alias that this package should be aliased to, optional * - alias_normalized: normalized alias that this package should be aliased to, optional
* *
* Any additional information can be returned and will be sent back
* into loadPackage/loadAliasPackage for completing the package loading
* when it's needed.
*
* @return array * @return array
*/ */
public function getMinimalPackages(); public function getMinimalPackages();